-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mainClass and jvmFlags cannot be set lazily on JibExtension in the Gradle plugin #3927
Comments
Hi @erdi. Thanks for bringing this up! We do welcome contributions to jib (https://github.com/GoogleContainerTools/jib/blob/master/CONTRIBUTING.md) and we'll gladly review any incoming PRs. @emmileaf FYI as you may have more context regarding this. |
Yes, enabling lazy evaluation for more of jib-gradle-plugin’s properties is something we would welcome help from the community on. @erdi As you’ve mentioned, this was previously done for a number of properties such as |
Thanks for the pointers to related issues/PRs, @emmileaf, they will definitely come handy. Let me see what I can do about this. |
FYI, @emmileaf, I've just opened a PR with a fix for this issue. |
Hi @wakingrufus, would you mind opening a separate issue to track this feature request and your implementation? I think this issue can be closed with #3936 already merged and released. Thanks! |
While many properties on
JibExtension
utilise lazy configuration APIs, including some of the more complex ones likelabels
, there are some, includingmainClass
andjvmFlags
, that do not. This forces users of the plugin to have to resort to usingProject.afterEvaluate()
in certain scenarios.Would you be willing to accept a PR if I addressed that?
The text was updated successfully, but these errors were encountered: