-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add armhf support for the forthcoming K8s release #638
Add armhf support for the forthcoming K8s release #638
Conversation
275a8ae
to
ca89296
Compare
Alright, I just did a GCB run with the changes I'm about to push, and this is one of the resulting images:
|
There are build failures. Seems related? |
@chanseokoh I must've messed something up in my second commit Friday, I'll TAL now. |
Looks like just a broken label in |
Oh, and please resolve the merge conflict. |
I'm also going to see what's left to move this to |
01ca474
to
2a5e189
Compare
Pushing the changed now. I'm going to submit a fresh GCB run to confirm things work there now. |
I forgot about the I've dropped |
@chanseokoh this should be RFAL. |
Thanks for thoroughly testing this! I'll try to get back to this by EOD. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One minor suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Let's give it a spin.
cc @hasheddan
This still needs the cloudbuild changes, which I'll stage and test ~now.