Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split cloudbuild.yaml scripts out into files #623

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

imjasonh
Copy link
Contributor

This avoids the annoying GCB arg length limit, and results in all Bazel
steps being run before all Docker steps.

@google-cla google-cla bot added the cla: yes CLAs look good label Oct 20, 2020
@chanseokoh
Copy link
Member

For consistency, can you rework java/cloudbuild.yaml too? Note GCB has other limits (e.g., max number of images). They increased the limit on the number of images to 200, but we've also added a lot of images. So I think it's safe to keep them separate, as we may be approaching the 200 limit.

@chanseokoh
Copy link
Member

Ah, forget about the max number of images. I forgot that the root cloudbuild.yaml pushes images directly instead of letting GCB do so. (OTOH, java/cloudbuild.yaml still relies on GCB to push.) So I guess we can merge them into a single build?

This avoids the annoying GCB arg length limit, and results in all Bazel
steps being run before all Docker steps.
@imjasonh
Copy link
Contributor Author

Added java/cloudbuild.yaml behavior

@chanseokoh
Copy link
Member

Let's try this out.

@chanseokoh chanseokoh merged commit 4d479f0 into GoogleContainerTools:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLAs look good
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants