Add Java 11 images (latest and debug) / add more tags #285
Conversation
chanseokoh
changed the title
|
So this generally matches the format of other java images: |
|
Yeah, we do plan to add more detailed tags along the way. It's just that I don't do everything in this PR. I think we can switch vendors for existing tags. Of course, we can add tags with vendors too (later). |
|
Can we put the version and vendor information as image labels? Putting this information into the tags will get pretty unwieldy. And there's no choice being offered to consumers: we're not planning to publish multiple vendors, and we're not maintaining parallel streams (e.g., 11.0.1 with security updates now that 11.0.2 is released). |
|
@chanseokoh were you going to offer jetty with java11 too? |
We have a plan to do this: #276
Eventually, this will happen. Could be soon, or maybe not. Hopefully soon? |
|
FYI: @saturnism, a more explicity tagging strategy. |
| ) for mode in [ | ||
| "", | ||
| ":debug", | ||
| ) for (rule_name, jre_deb, java_executable_path) in [ |
There was a problem hiding this comment.
Probably just get some bazel person to look at this, is there a way to share the java_executable_path reference or would that make this section look super wonky?
@nlopezgi wdyt?
There was a problem hiding this comment.
FYI, if you look at them closely, the java_executable_path values are different between Java 8 and Java 11. (Java 8 has the "jre" directory.) I could add an if-else logic like "add jre only when Java 8", but wasn't sure if it would look better than this.
There was a problem hiding this comment.
I don't feel super strongly about this. I was concerned about each java path could potentially be shared for each java8, java11 option, but it seems like it's not worth the trouble right now
About #236.
This is on top of #283, so #283 should be reviewed first.Debian stretch recently back-ported
openjdk-11. The Java 11 images get theopenjdk-11-jre-headless(in parity with the Java 8 images) from thestretch-backportssnapshot archive.gcr.io/distroless/java:latestandgcr.io/distroless/java:debugstill point to Java 8.Two new images:
gcr.io/distroless/java:11gcr.io/distroless/java:11-debugAdditional tags:
gcr.io/distroless/java:8gcr.io/distroless/java:8-debuggcr.io/distroless/java:11gcr.io/distroless/java:11-debuggcr.io/distroless/java/jetty:java8gcr.io/distroless/java/jetty:java8-debug