Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cloudbuild.yaml #286

Closed
chanseokoh opened this issue Jan 24, 2019 · 3 comments
Closed

Remove cloudbuild.yaml #286

chanseokoh opened this issue Jan 24, 2019 · 3 comments

Comments

@chanseokoh
Copy link
Member

chanseokoh commented Jan 24, 2019

It looks like the file was introduced as a workaround because the legacy docker_push rule stopped working. (Correct me if I'm wrong.) With the new rules (PR: #280), it works again in my testing.

@chanseokoh
Copy link
Member Author

chanseokoh commented Jan 25, 2019

But looks like there's an automatic publish hook using it (#283 (comment)), so I guess cloudbuild.yaml should stay for a while.

But now that #280 is merged, perhaps we could just have a single step at least.

steps:  
- name: gcr.io/cloud-builders/bazel
  args: ['run', '//:publish']

@chanseokoh
Copy link
Member Author

A deviation that cloudbuild.yaml producing additional tags: #297

@donmccasland
Copy link
Member

We are using cloudbuild and triggers to automatically build and publish images. We will not be changing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants