-
Notifications
You must be signed in to change notification settings - Fork 63
Fix lint & test errors #150
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Handler correctly returns "GET" for "Allow" header, whereas test was expecting nothing.
Webapp1 correctly returns 405 when calling an implemented method without handler.
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
========================================
- Coverage 95.81% 94.82% -1%
========================================
Files 17 16 -1
Lines 1818 1604 -214
Branches 274 252 -22
========================================
- Hits 1742 1521 -221
- Misses 19 33 +14
+ Partials 57 50 -7
Continue to review full report at Codecov.
|
Fixes #139 and #140
Mostly fixing this so someone can approve the other critical PRs ( such as #147 )