Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

Update mutex on google_apigee_instance_attachment to lock globally #646

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Update mutex on google_apigee_instance_attachment to lock globally #646

merged 1 commit into from
Apr 11, 2022

Conversation

modular-magician
Copy link
Contributor

This PR updates the mutex on google_apigee_instance_attachment to create a global lock.
It solves hashicorp/terraform-provider-google#11445.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Update mutex on google_apigee_instance_attachment to lock on org_id.

Derived from GoogleCloudPlatform/magic-modules#5911

@modular-magician @melinath
Update mutex on google_apigee_instance_attachment to lock globally (#…
5e2237a 
…5911)

* Add support IAM policy for the Environment of Apigee X

* Add support IAM policy for the Environment of Apigee X

* Add support IAM policy for the Environment of Apigee X

* Add support IAM policy for the Environment of Apigee X

* Revert all changes to test files.

* Revert all changes to test files.

* Revert all changes to test files.

* Add primary_resource_name to fix tests.

* Update iam_attributes.tf.erb to honor skip_test.

* Don't reject skip_tests when example is nil.

* Update mmv1/products/apigee/api.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Fix primary_resource_name for apigee organization name.

* Update mutex on google_apigee_instance_attachment to lock on org_id.

* Create a global lock on instance attachments.

* update mutex name to apigeeInstanceAttachments

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner April 11, 2022 22:16
@modular-magician modular-magician requested review from melinath and removed request for a team April 11, 2022 22:16
@modular-magician modular-magician merged commit 41c0f4d into GoogleCloudPlatform:main Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@melinath melinath Awaiting requested review from melinath melinath is a code owner automatically assigned from GoogleCloudPlatform/terraform-validator-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician