Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

Conversation

modular-magician
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#10779
Fixes hashicorp/terraform-provider-google#10434
Fixes hashicorp/terraform-provider-google#10387
Fixes hashicorp/terraform-provider-google#9755
Fixes hashicorp/terraform-provider-google#8374
Fixes hashicorp/terraform-provider-google#9189
Fixes hashicorp/terraform-provider-google#9883

Add support for REST fields sourceToBuild and gitFileSource which adds support for manual builds as well as adds support for webhook and pubsub triggered builds with source code.
Also added support for filter field that is used with webhook and pubsub triggered builds.
Also added examples for webhook, pubsub (with filter) and manual build.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudbuild: Add support for manual builds, git source for webhook/pubsub triggered builds and filter field

Derived from GoogleCloudPlatform/magic-modules#5738

…d builds and filter field (#5738)

* add filter support for cloudbuild

* Add support for sourceToBuild and gitFileSource. Add examples for pubsub_config, webhook_config trigger and manual mode

* Add support for sourceToBuild and gitFileSource. Add examples for pubsub_config, webhook_config trigger and manual mode

* Fix description for field uri in sourceToBuild to be required

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner March 4, 2022 17:40
@modular-magician modular-magician requested review from ScottSuarez and removed request for a team March 4, 2022 17:40
@modular-magician modular-magician merged commit b388f95 into GoogleCloudPlatform:main Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant