Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

Conversation

modular-magician
Copy link
Contributor

Add google_service_account for terraform validator
The converter is not existing and has to be created manually. Also, adding information into the converter list and add test cases.

Referring to #1290

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Derived from GoogleCloudPlatform/magic-modules#7146

* Add manual converter and tests for service_account

* Remove test expecting resource to be already existing

* Fix compute_instance test with service account

* Remove not needed comments

* Adding test for service account update

* Correct tf state file to match version 0.12.31

* Fixed copyright header year

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner February 3, 2023 18:46
@modular-magician modular-magician requested review from iyabchen and removed request for a team February 3, 2023 18:46
@modular-magician modular-magician merged commit 5a6afe2 into GoogleCloudPlatform:main Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant