feat: Add ability to disable lifecycle prevent_destroy #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the terraform under test or any modules in use have resources with a prevent_destroy = true in the lifecycle block any attempts to use destroy to clean up created resources will fail leaving resources in an unmanged state.
ludoo
approved these changes
Jan 23, 2022
There was a problem hiding this comment.
Thanks for this! One minor doubt on exception handling when manipulating files, and I'm also wondering if it would make sense to use pathlib everywhere for consistency, now that you introduced it. It does not need to happen in this PR, of course, I would just like your opinion.
|
Any idea when a version for this will be released? |
|
Actually had the tab open to remind me to do it, let me try and do it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix the issue described in #42
I have used features introduced in Python 3.5 and added a check in case people are using older versions of Python. If you think this needs to work on any version of Python 3 I'm happy to change the approach.
I have also only tested on MacOS, I assume in CI the tests ran under Linux. I'll try to get one of my colleagues who works on Windows to test this.