inspectConfig added to jobTrigger #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* inspectConfig added to jobTrigger * Test Precheck Updated * fields added to test * removed deprecated attributes contentOptions and detectionRules * customInfoTypes tests added covering all attributes * tabs removed from erb file and double space added * removed required from mentioned attributes * minor changes * Additional test for Exclusion Rule added * removing required from hotwordRegex and pattern * Spacing changed * immutable removed from customInfoType attributes * required removed from proximity * required removed from proximity and likelihoodAdjustment in rules * Tests modified and new cases added * added remaining 4 attr to test config * minor changes Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-4f6a2e76c526aa2b3d18ead7c7e8cfd6ef3ab44e
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
inspectConfigblock with all the attributes toinspectJobinjobTriggerresource and also added relevant test cases.If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#7677