Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: ignore case changes for DS records #701

Conversation

modular-magician
Copy link
Collaborator

DS records need case change suppression as with "MX" records.

Fixes hashicorp/terraform-provider-google#9093

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dns: suppress spurious diffs due to case changes in DS records

Derived from GoogleCloudPlatform/magic-modules#4769

DS records need case change suppression as with "MX" records.

Closes hashicorp/terraform-provider-google#9093

Signed-off-by: Modular Magician <[email protected]>
@google-cla google-cla bot added the cla: yes label May 6, 2021
@modular-magician modular-magician merged commit 4d97235 into GoogleCloudPlatform:master May 6, 2021
@modular-magician modular-magician deleted the downstream-pr-7f2462d1f9c1c2b461105694853c249d849cfc73 branch November 18, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant