Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow iam member to utilize casing for principle and principleSet #677

Conversation

modular-magician
Copy link
Collaborator

Revising to allow principal and principleSet to contain casing.

resolves hashicorp/terraform-provider-google#7852

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

iam: fixed issue with principle and principleSet members not retaining their casing 

Derived from GoogleCloudPlatform/magic-modules#4595

…595)

* Allow iam member to utilize casing for principle and principleSet

* Add integration test

* add testcases and custom diff supress for case sensitive value

* resolve comments

* normalizeCasing in id, add test for binding

* normalize iam import member casing

* add test for iam policy

* probably best to also support deleted behavior for princple and principleSet

* quantify teh set of values where this not the case in the function definition

* remove default go value

Signed-off-by: Modular Magician <[email protected]>
@google-cla google-cla bot added the cla: yes label Apr 6, 2021
@modular-magician modular-magician merged commit d3254d3 into GoogleCloudPlatform:master Apr 6, 2021
@modular-magician modular-magician deleted the downstream-pr-875f1e6cc7dc1135e88b0fef5084784a349b8b27 branch November 18, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle 3rd-party identities in IAM correctly
1 participant