Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apigee instance attachment resource #669

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#8666, fixes hashicorp/terraform-provider-google#8756

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_apigee_instance_attachment`

Derived from GoogleCloudPlatform/magic-modules#4619

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Added code for Apigee environment groups

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Incorporating review comments for Apigee environment groups

* Incorporating review comments for Apigee environment groups

* Update reverse_check_membership.sh

* Update reverse_check_membership.sh

* Update check_membership.sh

* Update mmv1/products/apigee/api.yaml

Co-authored-by: Sam Levenick <[email protected]>

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update mmv1/products/apigee/api.yaml

Co-authored-by: Sam Levenick <[email protected]>

* fixing .ci errors

* added code for instance attachments

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update reverse_check_membership.sh

* Update reverse_check_membership.sh

* Update check_membership.sh

* Update mmv1/products/apigee/api.yaml

Co-authored-by: Sam Levenick <[email protected]>

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update mmv1/products/apigee/api.yaml

Co-authored-by: Sam Levenick <[email protected]>

* fixing .ci errors

* added code for instance attachments

* fix for instance attachment create and delete

* instance attachment tests

* Update mmv1/templates/terraform/examples/apigee_instance_attachment_basic_test.tf.erb

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Update mmv1/templates/terraform/examples/apigee_instance_attachment_basic.tf.erb

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Made changes to instance attachment custom import

* removing depends_on as TF will implicitely calculate the dependencies now.

Co-authored-by: Sam Levenick <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@google-cla
Copy link

google-cla bot commented Mar 30, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Mar 30, 2021
@modular-magician modular-magician merged commit 21f6c0a into GoogleCloudPlatform:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apigee instance attachment resource Flakey tests: TestAccApigeeInstance_*
1 participant