Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Service Account Impersonation #551

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Implement Service Account Impersonation #551

merged 1 commit into from
Oct 15, 2020

Conversation

modular-magician
Copy link
Collaborator

Fixes: hashicorp/terraform-provider-google#7064
Fixes: hashicorp/terraform-provider-google#7351
Part of: hashicorp/terraform-provider-google#7332

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

provider: added support for service account impersonation.

Derived from GoogleCloudPlatform/magic-modules#4015

@modular-magician
Implement Service Account Impersonation (#4015)
2b2112f 
* add service account impersonation

* fix conflicts

* add the scopes block removed by error

* add service account impersonation

* undo spacing

* update docs for quota project

* fix typos in docs

* fix typo in test and the docs

* use the new gce client

* add impersonate to accesstoken + test

* fix tokensource typo

* replace the envs used for testing impersonation

* add additional scopes

* typo fix

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 5ff67cb into GoogleCloudPlatform:master Oct 15, 2020
@google-cla google-cla bot added the cla: yes label Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update docs to suggest adding a quota project to gcloud credentials Impersonating GCP service accounts
1 participant
@modular-magician