Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ENTERPRISE_PLUS as default Edition for POSTGRES_16 #2973

Conversation

modular-magician
Copy link
Collaborator

Current default: ENTERPRISE for settings.edition is not consistent with the API which treats EDITION_UNSPECIFIED as the default (refer link) when customer doesn't provide any. With PostgreSQL version 16, the default Edition will be ENTERPRISE_PLUS as documented in the PostgreSQL June 07, 2024 release notes. Thus, unset the default edition so that it can instead be computed in the API, allowing the API to use ENTERPRISE_PLUS as the default for POSTGRES_16.

b/338258663

I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

sql: removed the client-side default of `ENTERPRISE` for `edition` in `google_sql_database_instance` so that `edition` is determined by the API when unset. This will cause new instances to use `ENTERPRISE_PLUS` as the default for POSTGRES_16.

Derived from GoogleCloudPlatform/magic-modules#12077

Co-authored-by: Sarthak Tandon <[email protected]>

[upstream:385db4524531105c80b9aaf550da05d749de4ce6]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner October 23, 2024 01:55
@modular-magician modular-magician requested review from ScottSuarez and removed request for a team October 23, 2024 01:55
@modular-magician modular-magician merged commit 5695fe2 into GoogleCloudPlatform:main Oct 23, 2024
1 check passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician deleted the downstream-pr-385db4524531105c80b9aaf550da05d749de4ce6 branch November 18, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant