Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Transcoder API #2933

Conversation

modular-magician
Copy link
Collaborator

Closes #18328

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_transcoder_job`
`google_transcoder_job_template`

Tests:

 $ make testacc TEST=./google/services/transcoder TESTARGS='-run=TestAccTranscoderJob'
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/transcoder -v -run=TestAccTranscoderJob -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccTranscoderJob_transcoderJobBasicExample
=== PAUSE TestAccTranscoderJob_transcoderJobBasicExample
=== RUN   TestAccTranscoderJobTemplate_transcoderJobTemplateBasicExample
=== PAUSE TestAccTranscoderJobTemplate_transcoderJobTemplateBasicExample
=== RUN   TestAccTranscoderJobTemplate_transcoderJobTemplateOverlaysExample
=== PAUSE TestAccTranscoderJobTemplate_transcoderJobTemplateOverlaysExample
=== RUN   TestAccTranscoderJobTemplate_transcoderJobTemplateEncryptionsExample
=== PAUSE TestAccTranscoderJobTemplate_transcoderJobTemplateEncryptionsExample
=== RUN   TestAccTranscoderJobTemplate_transcoderJobTemplatePubsubExample
=== PAUSE TestAccTranscoderJobTemplate_transcoderJobTemplatePubsubExample
=== CONT  TestAccTranscoderJob_transcoderJobBasicExample
=== CONT  TestAccTranscoderJobTemplate_transcoderJobTemplateEncryptionsExample
=== CONT  TestAccTranscoderJobTemplate_transcoderJobTemplateOverlaysExample
=== CONT  TestAccTranscoderJobTemplate_transcoderJobTemplatePubsubExample
=== CONT  TestAccTranscoderJobTemplate_transcoderJobTemplateBasicExample
--- PASS: TestAccTranscoderJobTemplate_transcoderJobTemplateOverlaysExample (12.78s)
--- PASS: TestAccTranscoderJobTemplate_transcoderJobTemplateBasicExample (12.94s)
--- PASS: TestAccTranscoderJobTemplate_transcoderJobTemplateEncryptionsExample (24.99s)
--- PASS: TestAccTranscoderJob_transcoderJobBasicExample (30.70s)
--- PASS: TestAccTranscoderJobTemplate_transcoderJobTemplatePubsubExample (34.65s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/transcoder       36.049s

Derived from GoogleCloudPlatform/magic-modules#10932

Co-authored-by: Cameron Thornton <[email protected]>
Co-authored-by: BBBmau <[email protected]>

[upstream:c95102737c7c4909dfac79f26d582c42e97a1a8b]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner October 15, 2024 13:10
@modular-magician modular-magician requested review from ScottSuarez and removed request for a team October 15, 2024 13:10
@modular-magician modular-magician merged commit aa43152 into GoogleCloudPlatform:main Oct 15, 2024
3 checks passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician deleted the downstream-pr-c95102737c7c4909dfac79f26d582c42e97a1a8b branch November 18, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Provider Support for Transcoder API
1 participant