Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make backend service iap computed #2814

Conversation

modular-magician
Copy link
Collaborator

closes hashicorp/terraform-provider-google#19273

initially thought that it would need more than just Computed to get rid of the diffs, but testing has shown that this suffices.

Tested with a manual upgrade from 6.0.1 -> local build

6.0.1

  # google_compute_backend_service.lipsum will be updated in-place
  ~ resource "google_compute_backend_service" "lipsum" {
        id                              = "<id>"
        name                            = "<name>"
        # (22 unchanged attributes hidden)

      - iap {
          - enabled                     = true -> null
          - oauth2_client_id            = "test" -> null
          - oauth2_client_secret        = (sensitive value) -> null
          - oauth2_client_secret_sha256 = (sensitive value) -> null
        }

        # (1 unchanged block hidden)
    }

local build with Computed

    No changes. Your infrastructure matches the configuration.

Release Note Template for Downstream PRs (will be copied)

computed: fixed an issue where `iap` fields would not default to the API's value in `google_compute_backend` and `google_compute_region_backend`

Derived from GoogleCloudPlatform/magic-modules#11736

[upstream:7b77e871f1697f09d023c51841656a84c571a3f2]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner September 17, 2024 20:12
@modular-magician modular-magician requested review from iyabchen and removed request for a team September 17, 2024 20:12
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit b332907 into GoogleCloudPlatform:main Sep 17, 2024
4 of 6 checks passed
@modular-magician modular-magician deleted the downstream-pr-7b77e871f1697f09d023c51841656a84c571a3f2 branch November 18, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google compute backend service: iap parameter is no more optional for provider version >=6.0.0
1 participant