Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interconnect immutability issue causing macsec failure #2813

Conversation

modular-magician
Copy link
Collaborator

fixes hashicorp/terraform-provider-google#19410

Customer issue: b/365795490
When Customer tries to deploy an interconnect with macsec enabled. The deployment fails. The circuit needs to be deployed first before enabling macsec, however, if macsec is enabled after, it causes the circuit to be destroyed and recreated.
Interconnect can't created with macsec enabled.

Fix: remove immutability from the interconnect resource and add it at field level.

Release Note Template for Downstream PRs (will be copied)

compute: added in-place update in `google_compute_interconnect` resource except for `remote_location ` and `requested_features` fields

Derived from GoogleCloudPlatform/magic-modules#11700

[upstream:74483d6cc29cbe29f2c710efb4caa93f102d8324]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner September 17, 2024 18:34
@modular-magician modular-magician requested review from ScottSuarez and removed request for a team September 17, 2024 18:34
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit c17575a into GoogleCloudPlatform:main Sep 17, 2024
2 checks passed
@modular-magician modular-magician deleted the downstream-pr-74483d6cc29cbe29f2c710efb4caa93f102d8324 branch November 18, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support update-in-place for google_compute_interconnect resource
1 participant