Add google_site_verification_web_resource #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:8709d004700b220447e66093a751b029d007d023] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
melinath
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The adds support for the site verification API WebResource. It's step two out of three in implementing issue 5698. Step one was #10999 and step 3 will add the
ownersfield as a fine grained resource attached to this resource.There's two basic ways to verify ownership of a site: creating a DNS record or modifying the site's content. I've included tests for both, but the former is disabled under VCR as it requires dynamically creating a real, resolvable DNS record as part of the test. I know we have
gcp.tfacc.hashicorptest.comfor use in other tests, but I couldn't find an example of creating records in that zone.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11624