Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable goog-terraform-provisioned provider label #2689

Conversation

modular-magician
Copy link
Collaborator

Switch the goog-terraform-provisioned label added in v5.0.0 to be the default behavior. Fixes #18614.

This PR is starting out in draft form to locate affected tests (of which there many). I'll request a review once all the tests broken by this PR are running again.

Release Note Template for Downstream PRs (will be copied)

changed provider labels to add the `goog-terraform-provisioned: true` label by default.

Derived from GoogleCloudPlatform/magic-modules#11439

Co-authored-by: Cameron Thornton <[email protected]>

[upstream:0b62ec98517816a68148f8284a941b57ad21b4d4]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner August 20, 2024 16:45
@modular-magician modular-magician requested review from iyabchen and removed request for a team August 20, 2024 16:45
@modular-magician modular-magician merged commit b315273 into GoogleCloudPlatform:FEATURE-BRANCH-major-release-6.0.0 Aug 20, 2024
4 of 5 checks passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician deleted the downstream-pr-0b62ec98517816a68148f8284a941b57ad21b4d4 branch November 18, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant