Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Delayed Deletion for Vmwareengine Private Cloud #2505

Conversation

modular-magician
Copy link
Collaborator

  1. Adds support to delay the Private Cloud deletion . More information about the intended behavior can be found here.
  2. Modifies the region for vmwareengine resource tests to region 'me-west1' with allocated quota.
  3. Facilitates type change from TIME_LIMITED to STANDARD for multi-node Private Clouds

Release Note Template for Downstream PRs (will be copied)

vmwareengine: added `deletion_delay_hours` field to `google_vmwareengine_private_cloud` resource
vmwareengine: support type change from `TIME_LIMITED` to `STANDARD` for multi-node `google_vmwareengine_private_cloud` resource

Derived from GoogleCloudPlatform/magic-modules#10764

[upstream:b8a463edcd5a423613ca5aa1adf95f59095c2d73]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner July 10, 2024 17:48
@modular-magician modular-magician requested review from roaks3 and removed request for a team July 10, 2024 17:48
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit 35cacb6 into GoogleCloudPlatform:main Jul 10, 2024
5 of 6 checks passed
@modular-magician modular-magician deleted the downstream-pr-b8a463edcd5a423613ca5aa1adf95f59095c2d73 branch November 18, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant