Suppress private_endpoint_subnetwork when master_ipv4_cidr_block is set #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et (#10101) * Suppress private_endpoint_subnetwork when master_ipv4_cidr_block is set * acceptance test: Suppress private_endpoint_subnetwork when master_ipv4_cidr_block is set Signed-off-by: Francis Liu <[email protected]> --------- Signed-off-by: Francis Liu <[email protected]> [upstream:e6dbde8e5cde48677a57ce0667090ccd799cb29b] Signed-off-by: Modular Magician <[email protected]>
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
deleted the
downstream-pr-e6dbde8e5cde48677a57ce0667090ccd799cb29b
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For private flexible clusters, user are still allowed to set
master_ipv4_cidr_block. In this situation,private_endpoint_subnetworkwill return a non-empty subnet name, which doesn't match the empty subnet in Terraform config (user can set either cidr block or subnet, or neither, but not both, which is error-checked by API). We should ignore the subnet diff in this case. This PR is intended to fix the same issue #10089 attempted to fix. #10089 was reverted by #10096.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#10101