Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project_from_id provider-defined function #2001

Conversation

modular-magician
Copy link
Collaborator

To be merged after GoogleCloudPlatform/magic-modules#10013 Edit: done!

This PR:

  • adds the new project_from_id function to the providers
  • adds documentation for the Registry
  • adds unit tests to test reusable logic that will be used by other X_from_id functions
  • adds unit tests for function calls to the project_from_id function specifically - test good vs bad input
  • adds acceptance tests that demonstrate the function is usable with the provider and can be used in a single apply alongside provisioning a resource

Release Note Template for Downstream PRs (will be copied)

provider: added provider-defined function `project_from_id` for retrieving the project id from a resource's self link or id

Derived from GoogleCloudPlatform/magic-modules#10021

[upstream:8c31f796e6398267d8a383b1e804dd28837440bb]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner February 28, 2024 18:04
@modular-magician modular-magician requested review from iyabchen and removed request for a team February 28, 2024 18:04
@modular-magician modular-magician merged commit baddcf5 into GoogleCloudPlatform:FEATURE-BRANCH-provider-functions Feb 28, 2024
2 checks passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician deleted the downstream-pr-8c31f796e6398267d8a383b1e804dd28837440bb branch November 18, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant