Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: permadiff issue if event trigger region is not specified #1970

Conversation

modular-magician
Copy link
Collaborator

As per https://cloud.google.com/functions/docs/reference/rest/v2/projects.locations.functions#eventtrigger, the trigger_region if not provided, defaults to the same region as the function.

fixes hashicorp/terraform-provider-google#17161

Release Note Template for Downstream PRs (will be copied)

cloudfunctions2: fixed an issue where not specifying `event_config.trigger_region` in `google_cloudfunctions2_function` resulted in a permanent diff. The field now pulls a default value from the API when unset.

Derived from GoogleCloudPlatform/magic-modules#9989

* fixes: permadiff issue if event trigger region is not specified

- fixes hashicorp/terraform-provider-google#17161

* chore: Updated cloudfunction2 test with no explicit trigger_region

[upstream:02e719917fd193513b3e580493a2df4e051cafc9]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner February 20, 2024 20:00
@modular-magician modular-magician requested review from ScottSuarez and removed request for a team February 20, 2024 20:00
@modular-magician modular-magician merged commit 3299497 into GoogleCloudPlatform:main Feb 20, 2024
2 checks passed
@modular-magician modular-magician deleted the downstream-pr-02e719917fd193513b3e580493a2df4e051cafc9 branch November 18, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_cloudfunctions2_function TF changes at every plan
1 participant