Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding IAM support in Terraform for Dataform Repository resource #1707

Conversation

modular-magician
Copy link
Collaborator

Adding IAM support in Terraform for Dataform Repository resource
Internal tracking bug: b/309433506

Product Resource API Documentation: https://cloud.google.com/dataform/reference/rest/v1beta1/projects.locations.repositories

Did Manual Testing and it adds IAM policy to the repository added screenshots to the internal bug.

Release Note Template for Downstream PRs (will be copied)

dataform: added `google_dataform_repository_iam_*` IAM resources (beta)

Derived from GoogleCloudPlatform/magic-modules#9457

* Adding IAM support in Terraform for Dataform Repository resource

* Adding primary_resource_name property to Example

* Adding min-version: beta to IAM policy of repository resource

* Update import id used in acceptance tests

---------

Co-authored-by: Sarah French <[email protected]>
[upstream:d7adf2e72dfaa14737ed4d1881bf1ac4af916bdf]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner November 15, 2023 16:11
@modular-magician modular-magician requested review from shuyama1 and removed request for a team November 15, 2023 16:11
@modular-magician modular-magician merged commit 1962bef into GoogleCloudPlatform:main Nov 15, 2023
3 checks passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant