return nil instead of op, which is an interface containing nil

GoogleCloudPlatform · Dec 10, 2019 · 806c3d7 · 806c3d7
2 parents 43d9f58 + dd345f6
commit 806c3d7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/google/common_operation.go b/google/common_operation.go
@@ -117,7 +117,7 @@ func CommonRefreshFunc(w Waiter) resource.StateRefreshFunc {
 			for _, e := range getAllTypes(err, &googleapi.Error{}, &url.Error{}) {
 				if isRetryableError(e, predicates) {
 					log.Printf("[DEBUG] Dismissed error on GET of operation '%v' retryable: %s", w.OpName(), err)
-					return op, "done: false", nil
+					return nil, "done: false", nil
 				}
 			}
 
@@ -131,7 +131,7 @@ func CommonRefreshFunc(w Waiter) resource.StateRefreshFunc {
 		if err = w.Error(); err != nil {
 			if w.IsRetryable(err) {
 				log.Printf("[DEBUG] Retrying operation GET based on retryable err: %s", err)
-				return op, w.State(), nil
+				return nil, w.State(), nil
 			}
 			return nil, "", err
 		}