Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: consolidated logger names #22

Merged
merged 2 commits into from
Jul 10, 2023
Merged

feat: consolidated logger names #22

merged 2 commits into from
Jul 10, 2023

Conversation

telpirion
Copy link
Contributor

No description provided.

@balajismaniam
Copy link
Contributor

/gcbrun

balajismaniam
balajismaniam approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@balajismaniam balajismaniam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after tests pass.

@telpirion telpirion merged commit ee8ed5b into main Jul 10, 2023
@telpirion telpirion deleted the logger-names branch July 10, 2023 17:30
@release-please release-please bot mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balajismaniam balajismaniam balajismaniam approved these changes

@asrivas asrivas Awaiting requested review from asrivas

@yil532 yil532 Awaiting requested review from yil532

@nicain nicain Awaiting requested review from nicain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@telpirion @balajismaniam