Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add properties to customize universe-domain and host in Storage #3287
feat: add properties to customize universe-domain and host in Storage #3287
Changes from 9 commits
e493d3c
061be96
33872a6
476dde2
e5b3503
fa194d7
ff84418
45d0984
37bf0d8
9938248
5635a01
4af01b7
29cd19a
7e3de7e
de28054
02ca643
92e143e
a7beae4
cae2e8f
1d76e4f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we get this format from Storage client library code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we have it in java-core, is it where get it from? But we don't have the ending slash in java-core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks for the question. From doing a check with breakpoints in a spring storage app, Storage calls
getResolvedApiaryHost()
when setting the host at https://github.com/googleapis/java-storage/blob/7d47307d10e285f92b3e2125c4993b6a292001bf/google-cloud-storage/src/main/java/com/google/cloud/storage/HttpStorageOptions.java#L267.getResolvedApiaryHost()
returns a host with a/
so applied the same behavior here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Do you mind adding some comment regarding where we get the format from? I think a link to the implementation of
getResolvedApiaryHost()
in java-core should be good enough.In addition, anywhere we mention the format of
host
, we should always have an ending slash, which I see that it is missing in the Javadoc of universeDomain.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! Added a javadoc and also modified other locations where we mention host follow a consistent style.