chore: fix javadoc job by updating to the new javadoc output path

[mpeddada1]

The default javadoc output path was changed from target/site to target/reports in apache/maven-reporting-impl#26 and was introduced in maven-javadoc-plugin:3.10.0 in apache/maven-javadoc-plugin#204.

The maven-javadoc-plugin was updated from 3.8.0 to 3.10.0 in v5.6.0 (PR). This fix aims to address the current failure in the publish_javadoc job:

# Move into generated docs directory
pushd target/site/apidocs/
github/spring-cloud-gcp/.kokoro/publish_javadoc.sh: line 29: pushd: target/site/apidocs/: No such file or directory


[ID: 8846228] Command finished after 191 secs, exit value: 1

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[zhumin8]

Noticed the change was in "default value of output directory". I wonder if we can explicitly set this path in maven-javadoc-plugin, so we don't suffer similar issue in the future.

[mpeddada1]

Noticed the change was in "default value of output directory". I wonder if we can explicitly set this path in maven-javadoc-plugin, so we don't suffer similar issue in the future.

That's a great idea! There is an option to specify the <outputDirectory> in maven-javadoc-plugin. However, modifying this plugin to include the following snippet doesn't seem to address the error seen above (at least when I tested it locally):

<configuration>
	<outputDirectory>${project.build.directory}/site</outputDirectory>
</configuration>

Perhaps we can explore this long term solution as a follow-up?

[suztomo]

The default javadoc output path was changed from target/site to target/reports in apache/maven-reporting-impl#26 and was introduced in maven-javadoc-plugin:3.10.0 in apache/maven-javadoc-plugin#204.

That's great of you finding the source of the behavior change in upstream projects.