Skip to content

Commit

Permalink
chore: fixes compile error for security iap and firebase sample. (#1900)
Browse files Browse the repository at this point in the history
This fixes the compile error in iap-sample and firebase-sample and should unblock Spring Boot 3.1.0 #1874. 

However, iap sample does not run as described in [README](https://github.com/GoogleCloudPlatform/spring-cloud-gcp/blob/main/spring-cloud-gcp-samples/spring-cloud-gcp-security-iap-sample/README.adoc?plain=1#L52-L64) for me.
firebase sample also not working as expected.

Neither sample come with test and may have been broken before this change. Need to be further investigated.
Filed #1860 to track.
  • Loading branch information
zhumin8 authored May 31, 2023
1 parent 94a25c9 commit 584efe0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<java.version>1.8</java.version>
<java.version>17</java.version>
</properties>

<modelVersion>4.0.0</modelVersion>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<java.version>1.8</java.version>
<java.version>17</java.version>
</properties>

<!-- The Spring Framework on Google Cloud BOM will manage spring-cloud-gcp version numbers for you. -->
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
runtime: java11
runtime: java17
instance_class: F1

env_variables:
Expand Down

0 comments on commit 584efe0

Please sign in to comment.