Make spanner config mandatory #956
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync master
* Added the disable button option to connect to database * updated the error handling * updated the method name * resolve the comment * added UT --------- Co-authored-by: Vivek Yadav <[email protected]>
taherkl
requested review from
manitgupta and
darshan-sj
and removed request for
a team
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
asthamohta
reviewed
Dec 19, 2024
| ) {} | ||
|
|
||
| ngOnInit(): void { | ||
| this.data.isOffline.subscribe({ |
There was a problem hiding this comment.
This is non synchronous call, which I feel can call issues as we need to open the box synchronously
asthamohta
reviewed
Dec 19, 2024
| declarations: [HomeComponent], | ||
| imports: [MatMenuModule, MatDialogModule, RouterModule.forRoot(appRoutes), HttpClientModule], | ||
| imports: [MatMenuModule, MatDialogModule, RouterModule.forRoot(appRoutes), HttpClientModule,MatSnackBarModule], |
|
Hi @asthamohta As discussed, closing this PR as these changes are already incorporated in seperate PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here>
Currently, setting up of the Project ID and Spanner Instance ID is optional on the initial pages. With the new Verification API workflow, this is required to be mandatory. If the Spanner config are not set or invalid, the user shall receieve similar pop-up shown below before they can move forward with the schema migration.