Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for custom transformation #875

Merged
merged 10 commits into from
Aug 1, 2024
Merged

Documentation for custom transformation #875

merged 10 commits into from
Aug 1, 2024

Conversation

shreyakhajanchi
Copy link
Collaborator

@shreyakhajanchi shreyakhajanchi commented Jul 19, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Jul 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.06%. Comparing base (5874ce1) to head (0703fe1).
Report is 37 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #875      +/-   ##
==========================================
+ Coverage   44.77%   46.06%   +1.28%     
==========================================
  Files         163      166       +3     
  Lines       20937    21704     +767     
  Branches      478      515      +37     
==========================================
+ Hits         9374     9997     +623     
- Misses      11033    11138     +105     
- Partials      530      569      +39
Components Coverage Δ
backend-apis 45.42% <ø> (+2.68%) ⬆️
backend-library 52.18% <ø> (+0.84%) ⬆️
cli 5.14% <ø> (ø)
frontend 33.90% <ø> (+1.39%) ⬆️

see 46 files with indirect coverage changes

@shreyakhajanchi shreyakhajanchi marked this pull request as ready for review July 22, 2024 14:28
@shreyakhajanchi shreyakhajanchi requested a review from a team as a code owner July 22, 2024 14:28
@shreyakhajanchi shreyakhajanchi requested review from manitgupta and Deep1998 and removed request for a team July 22, 2024 14:28
manitgupta
manitgupta reviewed Jul 23, 2024
View reviewed changes
docs/minimal/transformations.md Outdated Show resolved Hide resolved
docs/minimal/transformations.md Outdated Show resolved Hide resolved
docs/minimal/transformations.md Outdated Show resolved Hide resolved
docs/minimal/transformations.md Outdated Show resolved Hide resolved
docs/reverse-replication/ReverseReplicationUserGuide.md Outdated Show resolved Hide resolved
docs/minimal/transformations.md Outdated Show resolved Hide resolved
@shreyakhajanchi shreyakhajanchi force-pushed the transformation-documentation branch from 7ef4602 to d58e30c Compare July 30, 2024 13:48
@shreyakhajanchi shreyakhajanchi marked this pull request as draft July 30, 2024 13:48
@shreyakhajanchi shreyakhajanchi marked this pull request as ready for review July 30, 2024 14:53
Deep1998
Deep1998 reviewed Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@Deep1998 Deep1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments

@shreyakhajanchi shreyakhajanchi merged commit 7cb785b into GoogleCloudPlatform:master Aug 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deep1998 Deep1998 Deep1998 approved these changes

@manitgupta manitgupta Awaiting requested review from manitgupta

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shreyakhajanchi @manitgupta @Deep1998