Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User guide and runner script for reverse replication #744

Merged
merged 9 commits into from
Jan 10, 2024

Conversation

aksharauke
Copy link
Collaborator

@aksharauke aksharauke commented Jan 9, 2024

The PR does the following:

  1. User guide is updated to reflect the latest GCS templates. Generated doc here: https://aksharauke.github.io/harbourbridge/reverse-replication
  2. The script to launch the GCS based templates is added.
  3. Deleted the old template script.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Merging #744 (0462877) into master (7b596d0) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #744   +/-   ##
=======================================
  Coverage   46.06%   46.06%           
=======================================
  Files         122      122           
  Lines       17120    17120           
  Branches      471      471           
=======================================
  Hits         7886     7886           
  Misses       8739     8739           
  Partials      495      495           
Components Coverage Δ
backend-apis 43.33% <ø> (ø)
backend-library 52.79% <ø> (ø)
cli 0.00% <ø> (ø)
frontend 31.96% <ø> (ø)

docs/reverse-replication/ReverseReplicationUserGuide.md Outdated Show resolved Hide resolved
docs/reverse-replication/ReverseReplicationUserGuide.md Outdated Show resolved Hide resolved
docs/reverse-replication/ReverseReplicationUserGuide.md Outdated Show resolved Hide resolved
docs/reverse-replication/ReverseReplicationUserGuide.md Outdated Show resolved Hide resolved
reverse_replication/reverse-replication-runner.go Outdated Show resolved Hide resolved
reverse_replication/reverse-replication-runner.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@Deep1998 Deep1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aksharauke aksharauke merged commit 330530f into GoogleCloudPlatform:master Jan 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants