Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

Add active debuggee support #76

Closed
jasonborg opened this issue Sep 20, 2022 · 1 comment
Closed

Add active debuggee support #76

jasonborg opened this issue Sep 20, 2022 · 1 comment
Assignees

Comments

@jasonborg
Copy link
Contributor

To support active debuggees, we need to add timestamp fields to Debuggees.

Two new fields will be required, which will be set/updated by the agents:

  • registrationTimeMsec
  • lastUpdateTimeMsec

The Agents when registering for the first time for a given debuggee ID will need to first perform a read from the DB to see if this is the first time a Debuggee is being registered or not. For simple re-registrations the lastUpdateTimeMsec would only need to be updated. The agents would be responsible for ensuring to periodically update lastUpdateTimeMsec as well so the Debuggee will remain active.

The CLI list_debuggees command will make use of these timestamps to only list the active debuggees by default.

@jasonborg jasonborg self-assigned this Sep 20, 2022
jasonborg added a commit to GoogleCloudPlatform/cloud-debug-java that referenced this issue Dec 2, 2022
The Firebase client now adds two new fields to the Debuggee entry in
the Firebase RTDB, `registrationTimeMsec` and `lastUpdateTimeMsec`.
The first time the Debuggee entry is written to the RTDB, both fields
are set. Thereafter only the `lastUpdateTimeMsec` will be changed, which
is done periodically every hour when the agent is running continuously,
it is also updated when the agent first starts up.
This is in support of
GoogleCloudPlatform/snapshot-debugger#76.
jasonborg added a commit to GoogleCloudPlatform/cloud-debug-java that referenced this issue Dec 5, 2022
The Firebase client now adds two new fields to the Debuggee entry in
the Firebase RTDB, `registrationTimeMsec` and `lastUpdateTimeMsec`.
The first time the Debuggee entry is written to the RTDB, both fields
are set. Thereafter only the `lastUpdateTimeMsec` will be changed, which
is done periodically every hour when the agent is running continuously,
it is also updated when the agent first starts up.
This is in support of
GoogleCloudPlatform/snapshot-debugger#76.
jasonborg added a commit that referenced this issue Dec 8, 2022
In support of #76 the `list_debuggees` command now:
- Shows only active debuggees by default
- Supports a `--include-inactive` flag
- Sorts the output with the most recently active debuggees being shown
  first.
jasonborg added a commit that referenced this issue Dec 9, 2022
In support of #76 the `list_debuggees` command now:
- Shows only active debuggees by default
- Supports a `--include-inactive` flag
- Sorts the output with the most recently active debuggees being shown
  first.
jasonborg added a commit that referenced this issue Dec 19, 2022
@jasonborg
Copy link
Contributor Author

This is now complete and released in v0.3.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant