feat: Add sample for blocking a request with particular header. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
|
/assign @wsh |
nkllkc
changed the title
wsh
reviewed
May 30, 2023
wsh
reviewed
May 30, 2023
martijneken
reviewed
Jul 7, 2023
| // limitations under the License. | ||
|
|
||
| #include "proxy_wasm_intrinsics.h" | ||
| #include <regex> |
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // [START serviceextensions_example_block_request] |
There was a problem hiding this comment.
nit: remove _example fragment from name, here and below
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #include "proxy_wasm_intrinsics.h" |
There was a problem hiding this comment.
Repeat [START] and [END] tags in the C++ sample
| @@ -30,6 +30,8 @@ plugin. Extend them to fit your particular use case. | |||
| * [Add HTTP request & response headers](samples/add_header): Add a header on | |||
| both the client request and server response paths. Also check for existing | |||
| headers. | |||
| * [Block Request with Particular Header Value](samples/block_request): Deny | |||
| a request whenever it contains a paritcular header set to certain value. | |||
There was a problem hiding this comment.
nit: s/paritcular/particular
|
@nkllkc - Just a health check. This PR seems to have no recent updates. PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a sample that checks the client referer header for a bad value, serve a synthetic 404 block with a basic html response (error not found).