Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow required_variable to only enforce on certain modes #738

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

linsword13
Copy link
Collaborator

gcp-metadata mod can use this, as it does not need hostlist when run in local mode.

Copy link
Collaborator

@douglasjacobsen douglasjacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! I've actually wanted this for a while, so it's nice to see it would help someone else. :)

I have one small request, but otherwise this LGTM.

lib/ramble/ramble/application.py Outdated Show resolved Hide resolved
gcp-metadata mod can use this, as it does not need `hostlist` when run
in local mode.
@linsword13 linsword13 merged commit 4b8c296 into GoogleCloudPlatform:develop Oct 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants