Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support globbing in directive list arguments #467

Merged

Conversation

dapomeroy
Copy link
Collaborator

Adds support for wildcards in list arguments within directives, so that arbitrary workloads can be supported more easily.

@dapomeroy dapomeroy force-pushed the directive_globbing branch 2 times, most recently from 874c81c to 6d1eaa1 Compare April 25, 2024 16:36
@dapomeroy dapomeroy marked this pull request as ready for review April 25, 2024 22:59
Copy link
Collaborator

@douglasjacobsen douglasjacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request. Otherwise LGTM! Thanks!

lib/ramble/ramble/language/application_language.py Outdated Show resolved Hide resolved
lib/ramble/ramble/language/modifier_language.py Outdated Show resolved Hide resolved
@dapomeroy dapomeroy force-pushed the directive_globbing branch 2 times, most recently from 483b6ee to 8c2bf33 Compare May 1, 2024 22:51
Adds support for wildcards in list arguments within directives, so that
arbitrary workloads can be supported more easily.
Adds a unit test for globbing of executables in workload directive of application definition.
Adds a mock modifier to test globbing on modifier mode selection.
@douglasjacobsen douglasjacobsen merged commit 493960c into GoogleCloudPlatform:develop May 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants