Allow expander to return string representation of invalid operators #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasjacobsen
added
bug
This commit updates the way binary operators work in the Expander.
Previously, if a string with binary operators was passed in (i.e.
`intel-mpi-benchmarks`) the binary operators were expected to actually
operate on numerical inputs. This caused unescaped string comparisons
(i.e. `{application_name} == intel-mpi-benchmarks`) to fail as the
expander would give a syntax error and not evaluate this statement.
This commit changes this behaivor to force the expander to return a
string representation of the args and binary operator:
(i.e. `intel-mpi-benchmarks` is returned as `'intel-mpi-benchmarks'`) to
allow these types of comparisons.
douglasjacobsen
force-pushed
the
fix_strings_in_expander
branch
from
efb7392
to
ce7f025
Compare
rfbgo
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge updates the way binary operators work in the Expander. Previously, if a string with binary operators was passed in (i.e.
intel-mpi-benchmarks) the binary operators were expected to actually operate on numerical inputs. This caused unescaped string comparisons (i.e.{application_name} == intel-mpi-benchmarks) to fail as the expander would give a syntax error and not evaluate this statement.This merge changes this behaivor to force the expander to return a string representation of the args and binary operator: (i.e.
intel-mpi-benchmarksis returned as'intel-mpi-benchmarks') to allow these types of comparisons.