Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Ramble 'concretized' flag #442

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

dapomeroy
Copy link
Collaborator

@dapomeroy dapomeroy commented Mar 19, 2024

Deprecates 'concretized' flag and config variable and replaces them with 'force_concretize' option to import default software configurations. This simplifies use of Ramble without Spack and helps prepare for support of additional package managers.

@dapomeroy dapomeroy force-pushed the promote_concretize branch 3 times, most recently from e32834e to 2f25397 Compare March 21, 2024 20:39
@dapomeroy dapomeroy marked this pull request as ready for review March 21, 2024 21:10
@dapomeroy dapomeroy changed the title Deprecate Ramble 'concretize' command Deprecate Ramble 'concretized' flag Mar 26, 2024
@dapomeroy dapomeroy force-pushed the promote_concretize branch 2 times, most recently from f3976d6 to 5a43ab4 Compare March 26, 2024 18:00
Deprecates 'concretized' flag and config variable and adds 'force_concretize' option. This simplifies use of Ramble without Spack and helps prepare for support of additional package managers.
Copy link
Collaborator

@rfbgo rfbgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

One small nit, and one question otherwise LGTM

lib/ramble/ramble/software_environments.py Show resolved Hide resolved
lib/ramble/ramble/software_environments.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@douglasjacobsen douglasjacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. One small change, and a request to make an internal task.

lib/ramble/ramble/cmd/workspace.py Outdated Show resolved Hide resolved
lib/ramble/ramble/software_environments.py Show resolved Hide resolved
lib/ramble/ramble/workspace/workspace.py Show resolved Hide resolved
@rfbgo rfbgo merged commit fd66a83 into GoogleCloudPlatform:develop Apr 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants