-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Ramble 'concretized' flag #442
Merged
rfbgo
merged 5 commits into
GoogleCloudPlatform:develop
from
dapomeroy:promote_concretize
Apr 2, 2024
Merged
Deprecate Ramble 'concretized' flag #442
rfbgo
merged 5 commits into
GoogleCloudPlatform:develop
from
dapomeroy:promote_concretize
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapomeroy
force-pushed
the
promote_concretize
branch
3 times, most recently
from
March 21, 2024 20:39
e32834e
to
2f25397
Compare
dapomeroy
changed the title
Deprecate Ramble 'concretize' command
Deprecate Ramble 'concretized' flag
Mar 26, 2024
dapomeroy
force-pushed
the
promote_concretize
branch
2 times, most recently
from
March 26, 2024 18:00
f3976d6
to
5a43ab4
Compare
Deprecates 'concretized' flag and config variable and adds 'force_concretize' option. This simplifies use of Ramble without Spack and helps prepare for support of additional package managers.
dapomeroy
force-pushed
the
promote_concretize
branch
from
March 26, 2024 18:02
5a43ab4
to
f07da78
Compare
rfbgo
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
One small nit, and one question otherwise LGTM
douglasjacobsen
requested changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. One small change, and a request to make an internal task.
rfbgo
approved these changes
Apr 2, 2024
douglasjacobsen
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates 'concretized' flag and config variable and replaces them with 'force_concretize' option to import default software configurations. This simplifies use of Ramble without Spack and helps prepare for support of additional package managers.