Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes property name #455

Merged
merged 1 commit into from
Aug 16, 2016
Merged

Changes property name #455

merged 1 commit into from
Aug 16, 2016

Conversation

WalterHub
Copy link
Contributor

Uses 'category' instead of 'type' as a property name.

'type' could cause confusion with data types.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2016
@theacodes
Copy link
Contributor

@dpebot merge when travis passes

@dpebot
Copy link
Collaborator

dpebot commented Aug 16, 2016

Okay! I'll merge when all statuses are green.

@dpebot dpebot added the automerge Merge the pull request once unit tests and other checks pass. label Aug 16, 2016
@theacodes theacodes merged commit 6ef9960 into GoogleCloudPlatform:master Aug 16, 2016
@WalterHub WalterHub deleted the working branch August 16, 2016 22:25
telpirion pushed a commit that referenced this pull request Nov 16, 2022
dandhlee pushed a commit that referenced this pull request Nov 18, 2022
telpirion pushed a commit that referenced this pull request Jan 18, 2023
Source-Link: googleapis/synthtool@52aef91
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:36a95b8f494e4674dc9eee9af98961293b51b86b3649942aac800ae6c1f796d4

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
dandhlee pushed a commit that referenced this pull request Feb 6, 2023
Source-Link: googleapis/synthtool@52aef91
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:36a95b8f494e4674dc9eee9af98961293b51b86b3649942aac800ae6c1f796d4

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
telpirion pushed a commit that referenced this pull request Mar 13, 2023
Source-Link: googleapis/synthtool@52aef91
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:36a95b8f494e4674dc9eee9af98961293b51b86b3649942aac800ae6c1f796d4

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants