-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bigtable samples to v2. #392
Conversation
eb39be2
to
7d27bd3
Compare
I think I've mentioned this elsewhere, but the READMEs in this repository mostly just link back to the docs. I don't like the idea of having duplicate instructions here. |
This LGTM once everything is ready. Feel free to merge. |
These instructions aren't duplicate. The docs contain no download or set up instructions, only code explanation. I'm waiting on googleapis/google-cloud-python#1940 before merging. |
googleapis/google-cloud-python#1940 has been merged so you're all set. |
Table of Contents generated with: doctoc --title '**Table of Contents**' bigtable Needs to wait for next gcloud-python launch. Tested locally with a previous version of grpcio.
7d27bd3
to
a981dcd
Compare
Uh, are you saying that in order for a user to use these samples they need to read both the docs and this readme? That seems wrong. |
Seemed wrong to me, too. I got some push-back from the tech writers when I tried to add this info to the docs. Basically, Google punishes sites for having duplicate content. https://support.google.com/webmasters/answer/66359?hl=en I just forwarded a thread to the group that has more context. |
Cool, let's resolve it there. The readme here can stay. |
Table of Contents generated with:
Needs to wait for next gcloud-python launch so that googleapis/google-cloud-python#1932 can go in. Tested locally on the bigtable-v2 branch of gcloud-python with a
previous version of grpcio.