Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bigtable samples to v2. #392

Merged
merged 1 commit into from
Jun 29, 2016
Merged

Update Bigtable samples to v2. #392

merged 1 commit into from
Jun 29, 2016

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jun 29, 2016

Table of Contents generated with:

doctoc --title '**Table of Contents**' bigtable

Needs to wait for next gcloud-python launch so that googleapis/google-cloud-python#1932 can go in. Tested locally on the bigtable-v2 branch of gcloud-python with a
previous version of grpcio.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 29, 2016
@tswast tswast changed the title Update Bigtable samples to v2. Update Bigtable samples to v2. [DO NOT MERGE] Jun 29, 2016
@theacodes
Copy link
Contributor

I think I've mentioned this elsewhere, but the READMEs in this repository mostly just link back to the docs. I don't like the idea of having duplicate instructions here.

@theacodes
Copy link
Contributor

This LGTM once everything is ready. Feel free to merge.

@tswast
Copy link
Contributor Author

tswast commented Jun 29, 2016

These instructions aren't duplicate. The docs contain no download or set up instructions, only code explanation.

I'm waiting on googleapis/google-cloud-python#1940 before merging.

@mbrukman
Copy link
Contributor

googleapis/google-cloud-python#1940 has been merged so you're all set.

Table of Contents generated with:

    doctoc --title '**Table of Contents**' bigtable

Needs to wait for next gcloud-python launch. Tested locally with a
previous version of grpcio.
@tswast tswast changed the title Update Bigtable samples to v2. [DO NOT MERGE] Update Bigtable samples to v2. Jun 29, 2016
@theacodes
Copy link
Contributor

The docs contain no download or set up instructions, only code explanation.

Uh, are you saying that in order for a user to use these samples they need to read both the docs and this readme? That seems wrong.

@tswast
Copy link
Contributor Author

tswast commented Jun 29, 2016

That seems wrong.

Seemed wrong to me, too. I got some push-back from the tech writers when I tried to add this info to the docs.

Basically, Google punishes sites for having duplicate content. https://support.google.com/webmasters/answer/66359?hl=en
So this is a compromise. Docs can explain and if they want to run, they go to the README.

I just forwarded a thread to the group that has more context.

@theacodes
Copy link
Contributor

Cool, let's resolve it there. The readme here can stay.

@tswast tswast merged commit 2fa20c0 into master Jun 29, 2016
@tswast tswast deleted the tswast-bigtable-v2 branch June 29, 2016 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants