Add missing instructions for test project setup. #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -38,4 +38,4 @@ echo "Creating pubsub resources." | |||
| gcloud alpha pubsub topics create gae-mvm-pubsub-topic | |||
|
|
|||
| echo "To finish setup, follow this link to enable APIs." | |||
| echo "https://console.cloud.google.com/flows/enableapi?apiid=datastore,pubsub,storage_api,logging,plus,bigquery,cloudmonitoring,compute_component" | |||
| echo "https://console.cloud.google.com/flows/enableapi?project=${GCLOUD_PROJECT}&apiid=bigquery,cloudmonitoring,compute_component,datastore,dataproc,dns,plus,pubsub,logging,storage_api,vision.googleapis.com" | |||
There was a problem hiding this comment.
probably need to add datastore.googleapis.com here (datastore v1beta3)
There was a problem hiding this comment.
Done in latest commit.
I don't remember having to enable that API. It could be on by default, but explicit is better than implicit.
Also, update the script to prepare a new project for testing.
msampathkumar
pushed a commit
that referenced
this pull request
Nov 14, 2022
8 tasks
engelke
pushed a commit
that referenced
this pull request
Nov 28, 2022
dandhlee
pushed a commit
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing sections to script and environment variables needed when running
nox -s testson a new project.