Added blobstore image example #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| # [START all] | ||
| # [START thumbnailer] | ||
| from google.appengine.api import images | ||
| from google.appengine.ext import blobstore |
There was a problem hiding this comment.
blobstore should be above images, lint will fail otherwise.
There was a problem hiding this comment.
Lint passes for me?
There was a problem hiding this comment.
Sorry, I'm dumb and mis-read ext and api. This is fine.
|
LGTM with small nit |
|
|
||
| def test_img(app): | ||
| with mock.patch('blobstore.images') as mock_images: | ||
| with mock.patch('blobstore.blobstore') as mock_blobstore: |
There was a problem hiding this comment.
can we make these decorators? less nesting so a little cleaner imo
There was a problem hiding this comment.
Can do this after closing the bug
|
Can we merge this? |
|
Sure. |
nicain
pushed a commit
that referenced
this pull request
Nov 2, 2022
8 tasks
donmccasland
pushed a commit
that referenced
this pull request
Nov 2, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 7, 2022
msampathkumar
pushed a commit
that referenced
this pull request
Nov 9, 2022
8 tasks
msampathkumar
pushed a commit
that referenced
this pull request
Nov 9, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 15, 2022
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Nov 16, 2022
msampathkumar
pushed a commit
that referenced
this pull request
Nov 17, 2022
arbrown
pushed a commit
that referenced
this pull request
Nov 17, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 17, 2022
m-strzelczyk
pushed a commit
that referenced
this pull request
Nov 18, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 18, 2022
engelke
pushed a commit
that referenced
this pull request
Nov 28, 2022
dandhlee
pushed a commit
that referenced
this pull request
Nov 29, 2022
holtskinner
pushed a commit
that referenced
this pull request
Jan 3, 2023
8 tasks
holtskinner
pushed a commit
that referenced
this pull request
Jan 4, 2023
dandhlee
pushed a commit
that referenced
this pull request
Jan 5, 2023
8 tasks
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
…#291) * chore(python): run blacken session for all directories with a noxfile Source-Link: googleapis/synthtool@bc0de6e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:39ad8c0570e4f5d2d3124a509de4fe975e799e2b97e0f58aed88f8880d5a8b60 * lint Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Jun 8, 2023
parthea
pushed a commit
that referenced
this pull request
Jun 8, 2023
dizcology
pushed a commit
that referenced
this pull request
Sep 11, 2023
9 tasks
leahecole
pushed a commit
that referenced
this pull request
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.