Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed 'speech_transcribe_infinite_streaming_init' region tag #2456

Merged
merged 5 commits into from
Oct 8, 2019

Conversation

bradmiro
Copy link
Collaborator

@bradmiro bradmiro commented Oct 8, 2019

Deleted region tag as it didn't make sense in the context of the other samples

gguuss and others added 5 commits October 7, 2019 18:45
* App engine upversion

* Python 2 compatible pytest
* Updated requirements

* Update service naming convention

* Prefer client libraries over shell commands

* Update README format
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 8, 2019
@bradmiro bradmiro merged commit be45ca8 into bradmiro-stage Oct 8, 2019
@alixhami
Copy link
Contributor

alixhami commented Oct 8, 2019

This PR is pretty confusing. It looks like a lot more happened than just a region tag removal. Are you sure this didn't undo a bunch of other unrelated commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants