Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageMagick: use separate bucket for blurred images. #2199

Merged
merged 3 commits into from
Jun 8, 2019
Merged

ImageMagick: use separate bucket for blurred images. #2199

merged 3 commits into from
Jun 8, 2019

Conversation

ace-n
Copy link

@ace-n ace-n commented Jun 7, 2019

@tbpg FYI

Related PR: GoogleCloudPlatform/nodejs-docs-samples#1346
Googlers: See also cl/251939574

@ace-n ace-n requested a review from engelke June 7, 2019 02:08
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 7, 2019
engelke
engelke approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though you might want to slightly change wording noted above.

@ace-n ace-n merged commit 38ccb43 into master Jun 8, 2019
@ace-n ace-n deleted the fix-b121041642 branch June 8, 2019 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke engelke approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ace-n @engelke @googlebot