-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gen ai): showcase different options for computation-based metric #12756
base: main
Are you sure you want to change the base?
Conversation
@@ -37,7 +39,37 @@ def get_rouge_score() -> EvalResult: | |||
life, including endangered species, it faces serious threats from | |||
climate change, ocean acidification, and coral bleaching.""" | |||
|
|||
# Compare pre-generated model responses against the reference (ground truth). | |||
# Option1: Run model inference and evaluate model response against the reference (ground truth) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code samples looks too big now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I understand
@@ -37,7 +39,37 @@ def get_rouge_score() -> EvalResult: | |||
life, including endangered species, it faces serious threats from | |||
climate change, ocean acidification, and coral bleaching.""" | |||
|
|||
# Compare pre-generated model responses against the reference (ground truth). | |||
# Option1: Run model inference and evaluate model response against the reference (ground truth) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msampathkumar , I'm thinking about showcasing 2 different options of using the computation-based metrics — Bring-your-own-response (BYOR) and with running model inference.
The reason is that for me, as a developer, the line between these options wasn't immediately obvious (hence this issue with the "prompt" column being silently unused), so I want to make it crystal-clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I understand your point, this code samples is still too big(100 lines). Let me check with the tech writing team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also note, I don't see any example response section for this part of the code.
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)