Add samples for Cloud Tasks #1068

andrewsg · 2017-08-11T22:25:59Z

Add samples for Cloud Tasks using the Apiary library.

andrewsg · 2017-08-11T22:26:56Z

These samples contain an appengine app (for appengine queues) AND a command-line toolkit (for pull queues). I've placed them in the appengine/flexible directory for now but we could put it in a top-level directory instead if needed.

theacodes

I would definitely prefer the pull queue samples to be under tasks/api-client.

theacodes · 2017-08-14T15:53:14Z

appengine/flexible/tasks/README.md

+
+See the respective READMEs for detailed instructions.
+
+## Contributing changes


You can drop this section and the next.

theacodes · 2017-08-14T15:54:24Z

appengine/flexible/tasks/appengine_queues/README.md

+
+## Prerequisites to run locally:
+
+The samples require a Python environment with


Can you just link to https://cloud.google.com/python/setup?

(I really need to finish the autogenerator for web samples)

theacodes · 2017-08-14T15:54:45Z

appengine/flexible/tasks/appengine_queues/README.md

+[pip](https://pypi.python.org/pypi/pip) installed.
+[virtualenv](https://virtualenv.readthedocs.org/en/latest/) is also recommended.
+
+All samples require a Google Cloud Project whitelisted for the Cloud Tasks API.


Is whitelisting required in beta?

theacodes · 2017-08-14T15:55:13Z

appengine/flexible/tasks/appengine_queues/README.md

+
+## Authentication
+
+To set up authentication locally, download the


Can you just link to https://cloud.google.com/docs/authentication?

On hold until I rewrite to use service account auth (shortly)

theacodes · 2017-08-14T15:55:36Z

appengine/flexible/tasks/appengine_queues/README.md

+
+## Creating a queue
+
+Queues can not currently be created by the API. To create a queue using the


Is this still true in beta?

No, it is not. Changing the samples to reflect this is coming up but for now I'll at least scrub this from the docs. Done

theacodes · 2017-08-14T16:07:06Z

appengine/flexible/tasks/appengine_queues/main.py

+
+
+@app.route('/set_payload', methods=['POST'])
+def set_payload():


A nit about names - there is a get_payload and set_payload function pair for HTTP and a get_payload_from_datastore and update_payload pair for actually talking to the database. It would be nice to have actual pairity - perhaps set_payload_view and get_payload_view to match set_payload and get_payload.

Agree, but will defer because all of this will be replaced shortly to remove the Datastore dependency outright.

theacodes · 2017-08-14T16:07:27Z

appengine/flexible/tasks/appengine_queues/requirements-test.txt

@@ -0,0 +1,2 @@
+pytest=3.0.3


You can drop this file.

theacodes · 2017-08-14T16:08:11Z

appengine/flexible/tasks/pull_queues/README.md

@@ -0,0 +1,94 @@
+# Google Cloud Tasks Pull Queue Samples


Since this is a command-line sample, can you use the readme generator? (see storage/cloud-client/README.rst.in for an example.)

Okay, will have to look into how that works, I'll add it to the list.

theacodes · 2017-08-14T16:08:30Z

appengine/flexible/tasks/pull_queues/pull_queue_snippets.py

+
+"""Sample command-line program for interacting with the Cloud Tasks API.
+
+Please note that Cloud Tasks is currently in alpha.


theacodes · 2017-08-14T16:09:51Z

appengine/flexible/tasks/pull_queues/pull_queue_snippets.py

+
+if __name__ == '__main__':
+    parser = argparse.ArgumentParser(description=__doc__,
+                                     formatter_class=argparse.RawDescriptionHelpFormatter)


please no hanging indents.

(http://docs.python-requests.org/en/master/dev/contributing/#kenneth-reitz-s-code-style)

andrewsg · 2017-08-31T00:09:19Z

PTAL when you're ready.

tristanvanech · 2017-08-31T23:57:38Z

appengine/flexible/tasks/README.md

-the `--in_seconds` flag:
-
-    python app_engine_queue_snippets.py --api_key=$API_KEY create-task --queue_name=$QUEUE_NAME --payload=hello --in_seconds=30
+   python create_app_engine_queue_task.py --project=$PROJECT_ID --queue=QUEUE_ID --location=LOCATION_ID --payload=hello


$ before variable names

tristanvanech · 2017-08-31T23:58:55Z

appengine/flexible/tasks/README.md


-    https://console.cloud.google.com/logs
+    python create_app_engine_queue_task.py --project=$PROJECT_ID --queue=QUEUE_ID --location=LOCATION_ID --payload=hello --in_seconds=30


$ before variable names

tristanvanech · 2017-09-01T00:01:39Z

appengine/flexible/tasks/README.md


-    gcloud app deploy queue.yaml
+    gcloud alpha tasks queues create-app-engine-queue "my-appengine-queue"


you don't need to put the queue ID in quotes

tristanvanech · 2017-09-01T00:03:39Z

appengine/flexible/tasks/README.md


-    export QUEUE_NAME=projects/$PROJECT_ID/locations/$LOCATION_ID/queues/$QUEUE_ID
+    export LOCATION_ID=us-central1

 Create a task, targeted at the `set_payload` endpoint with a payload specified:


Shouldn't this be log_payload?

tristanvanech · 2017-09-01T00:05:15Z

appengine/flexible/tasks/README.md

+
+On App Engine, authentication credentials will be automatically detected.
+
+On Compute Engine and Container Engine, authentication credentials will be


Are these necessary? Isn't the tutorial for App Engine queues targeted at App Engine endpoints?

tristanvanech · 2017-09-01T00:05:22Z

appengine/flexible/tasks/README.md

+automatically detected, but the instances must have been created with the
+necessary scopes.
+
+In any other environment, for example a Compute Engine instance without the


same as above

tristanvanech · 2017-09-01T00:06:04Z

appengine/flexible/tasks/README.md

+
+    gcloud auth application-default login
+
+On App Engine, authentication credentials will be automatically detected.


So is application-default login even necessary?

This authentication is for the component submitting the tasks, not for the app engine target of the tasks. The component submitting the tasks can be anywhere, not just on app engine.

tristanvanech · 2017-09-07T23:16:45Z

appengine/flexible/tasks/README.md

-the `--in_seconds` flag:
-
-    python app_engine_queue_snippets.py --api_key=$API_KEY create-task --queue_name=$QUEUE_NAME --payload=hello --in_seconds=30
+   python create_app_engine_queue_task.py --project=$PROJECT_ID --queue=QUEUE_ID --location=LOCATION_ID --payload=hello


curious why the queue_name parameter was removed in favor of breaking it out into three components? While I think the naming conventions of "queue name" vs. "queue" vs. "queue ID" are hard to follow, they're apparently in line with OnePlatform. Further, when we want to add more params like headers, App Engine routing, relative URL, and response view, the command will get pretty long.

I removed queue_name because gcloud queues list doesn't show the queue name. There's no real way to discover it without hitting the API separately. The queue name construct is still visible in the code itself, which seems appropriate for a sample.

But the describe command does, which is what you're using to get the location anyway.

Oh, that's right. I think using the "queue_name" is an awkward abstraction, but since "describe" shows the queue_name I could add it back in. I'll reconsider.

I discussed with Jon and he told me that our other samples that have resource paths under the hoods use a similar "pass in the components on the command line, and assemble the full path in the code itself" system. So, I think I'll keep it like this for now. I think it's awkward to have the user use "describe" to look at the resource path just to get the location out of it, but I've been assured that the resource path will be included in "list" output soon at which point that will no longer be necessary.

tristanvanech · 2017-09-07T23:34:26Z

appengine/flexible/tasks/README.md


-View all queues:
+Then the queue ID, as specified at queue creation time. Queue IDs already
+created can be listed with `gcloud alpha tasks queue list`.


the command is queues plural

tristanvanech · 2017-09-07T23:34:39Z

appengine/flexible/tasks/README.md


-Set the queue name as an environment variable:
+And finally the location ID, which can be discovered with
+`gcloud alpha tasks queue describe $QUEUE_ID`, with the location embedded in the


queues plural

duggelz · 2017-09-11T20:49:13Z

appengine/flexible/tasks/README.md

@@ -0,0 +1,105 @@
+# Google Cloud Tasks App Engine Queue Samples


Do any of the instances of "App Engine" in this document need to be "App Engine Standard" or "App Engine Flexible"? If not, can we actually explicitly say that "works in both App Engine Standard and Flexible"? I work at Google and I don't know, so I can only imagine our customers might have the same question.

It works for both standard and flex.

duggelz · 2017-09-11T20:50:53Z

appengine/flexible/tasks/create_app_engine_queue_task.py

+    queue_name = 'projects/{}/locations/{}/queues/{}'.format(
+        project, location, queue)
+
+    print('Sending task {}'.format(pprint.pformat(body)))


Might it be even better to print this as JSON?

theacodes · 2017-09-12T17:41:38Z

appengine/flexible/tasks/README.md

+
+Please refer to [Setting Up a Python Development Environment](https://cloud.google.com/python/setup).
+
+## Authentication


Can you just link to our central auth docs?

You mean just link to this page: https://cloud.google.com/docs/authentication/ ? It seems way, way too complex for users who just want to run the samples. I'm not even clear on where I would click on this page in order to figure out how to run them.

Specifically I meant here: https://cloud.google.com/docs/authentication/getting-started

We should no longer recommend gcloud auth to users.

Okay, I'll replace these sections with that link.

theacodes · 2017-09-12T17:42:48Z

appengine/flexible/tasks/create_app_engine_queue_task.py

+    return response
+
+
+def get_client():


prefer that you just put this inline in the function above.

theacodes · 2017-09-12T17:43:00Z

appengine/flexible/tasks/create_app_engine_queue_task.py

+
+def get_client():
+    """Build an http client."""
+    DISCOVERY_URL = 'https://cloudtasks.googleapis.com/$discovery/rest?version=v2beta2'


it's not a constant, so it doesn't need to be capital.

It's not a constant? It's not modified or replaced anywhere, it's just a string literal with a name, right?

theacodes · 2017-09-12T17:43:35Z

appengine/flexible/tasks/main.py

+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""App Engine app to serve as an endpoint for App Engine queue samples."""


This is for push queues, yeah? Can we be explicit about that?

Yeah, I asked about it but I was told by the PM that the "push queue" terminology is being dropped in favor of "App Engine queue".

theacodes · 2017-09-12T17:44:17Z

tasks/README.md

+
+Please refer to [Setting Up a Python Development Environment](https://cloud.google.com/python/setup).
+
+## Authentication


Please link to our central auth guide instead of using gcloud auth application-default login.

theacodes · 2017-09-12T17:44:54Z

tasks/pull_queue_snippets.py

+    print('Acknowledged task {}'.format(task['name']))
+
+
+def get_client(api_key):


As before, I prefer this to be inline with the samples.

Done, and revamped to remove API-key isms

theacodes · 2017-09-12T17:45:45Z

tasks/pull_queue_snippets.py

+    next_page_token = None
+
+    while True:
+        response = client.projects().locations(


you can avoid this awkwardness by doing:

queues_api = client.projects().locations().queues() response = queues_api.list(...)

theacodes · 2017-09-12T17:45:59Z

tasks/pull_queue_snippets.py

+
+    while True:
+        response = client.projects().locations(
+            ).queues().list(parent=parent,pageToken=next_page_token).execute()


Does this not have list_next?

…y auth

andrewsg · 2017-09-14T20:58:33Z

@jonparrott PTAL -- still working on converting the pull queue README though.

… line input, readme

andrewsg · 2017-09-14T21:36:39Z

Okay, README changes done along with extensive improvements to pull queues samples. Tests pass on my machine.

…-samples#1068) * Add samples for Cloud Tasks * Respond to tasks sample review * Update app engine queues samples * Address review feedback * Address review issues and convert pull queue sample to not use API key auth * Reform pull queues to match appengine queues changes to auth, command line input, readme * flake8 and fix comment

* Add samples for Cloud Tasks [(#1068)](GoogleCloudPlatform/python-docs-samples#1068) * Add samples for Cloud Tasks * Respond to tasks sample review * Update app engine queues samples * Address review feedback * Address review issues and convert pull queue sample to not use API key auth * Reform pull queues to match appengine queues changes to auth, command line input, readme * flake8 and fix comment * Fix Tasks sample test issues. * Remove queue.yaml, now unused * Add required flag on certain arguments to command-line tools * Auto-update dependencies. [(#1116)](GoogleCloudPlatform/python-docs-samples#1116) * Auto-update dependencies. [(#1133)](GoogleCloudPlatform/python-docs-samples#1133) * Auto-update dependencies. * Fix missing http library Change-Id: I99faa600f2f3f1f50f57694fc9835d7f35bda250 * Update Task Queue samples for beta * Use full import to get client * Auto-update dependencies. [(#1186)](GoogleCloudPlatform/python-docs-samples#1186) * Auto-update dependencies. [(#1217)](GoogleCloudPlatform/python-docs-samples#1217) * Added "Open in Cloud Shell" buttons to README files [(#1254)](GoogleCloudPlatform/python-docs-samples#1254) * Add comments and region tags to Cloud Tasks samples [(#1271)](GoogleCloudPlatform/python-docs-samples#1271) * Standardize on CamelCase, reword confusing endpoint name [(#1288)](GoogleCloudPlatform/python-docs-samples#1288) * Auto-update dependencies. [(#1309)](GoogleCloudPlatform/python-docs-samples#1309) * Rename pull to lease and fix name/parent confusion [(#1311)](GoogleCloudPlatform/python-docs-samples#1311) * Updated region tags for pull queue samples [(#1329)](GoogleCloudPlatform/python-docs-samples#1329) * Auto-update dependencies. [(#1320)](GoogleCloudPlatform/python-docs-samples#1320) * Auto-update dependencies. [(#1355)](GoogleCloudPlatform/python-docs-samples#1355) * Auto-update dependencies. [(#1359)](GoogleCloudPlatform/python-docs-samples#1359) * Auto-update dependencies. * Update Cloud Tasks Samples [(#1529)](GoogleCloudPlatform/python-docs-samples#1529) * passing create task * Passing tests * updates to region tags * update region tags [(#1532)](GoogleCloudPlatform/python-docs-samples#1532) * update Tasks Sample for App Engine [(#1541)](GoogleCloudPlatform/python-docs-samples#1541) * update gcloud command for creating queues * deploys and runs * update license * passing tests * Fix run command [(#1563)](GoogleCloudPlatform/python-docs-samples#1563) * Updated library for TTS GA [(#1552)](GoogleCloudPlatform/python-docs-samples#1552) * update gcloud command for Cloud Tasks [(#1566)](GoogleCloudPlatform/python-docs-samples#1566) * update gcloud command * update pull queue command * update pull queue command * Update Cloud Tasks Push Queue Sample [(#1698)](GoogleCloudPlatform/python-docs-samples#1698) * deleted pull queues * updated samples * fix dependency versions * [Cloud Tasks] Move samples to new folder [(#2114)](GoogleCloudPlatform/python-docs-samples#2114) * Move samples to keep consistent with other langauges * Ad system tests as well * [Cloud Tasks] Add task with authentication sample [(#2113)](GoogleCloudPlatform/python-docs-samples#2113) * Add task with authentication sample * Fix linting * Fix linting * Fix spacing * Update tests with service account * Move samples and update READMEs * Update version and linting * Update task sample comments [(#2156)](GoogleCloudPlatform/python-docs-samples#2156) * Update task comments * Update readme * Update queue name * update gcloud [(#2208)](GoogleCloudPlatform/python-docs-samples#2208) * Add protobuf dep and install instructions [(#2250)](GoogleCloudPlatform/python-docs-samples#2250) * Add Migration Guide Snippets for Cloud Tasks [(#2316)](GoogleCloudPlatform/python-docs-samples#2316) * Migration guide * remove app and update migraitonn * snippets for migration guide - tests added * lint * remove print statements * Styling changes * Travis trigger * Update create_http_task.py [(#2187)](GoogleCloudPlatform/python-docs-samples#2187) Updates `create_http_task.py` to have missing `in_seconds` variable * Adds updates for samples profiler ... vision [(#2439)](GoogleCloudPlatform/python-docs-samples#2439) * Update Cloud Tasks library version [(#2516)](GoogleCloudPlatform/python-docs-samples#2516) * Update to new library * update library version * Adds Task name while creating Task [(#2543)](GoogleCloudPlatform/python-docs-samples#2543) * Task Name in Creating HTTP Task with Token [(#2700)](GoogleCloudPlatform/python-docs-samples#2700) * chore(deps): update dependency google-cloud-tasks to v1.5.0 [(#3168)](GoogleCloudPlatform/python-docs-samples#3168) * chore(deps): update dependency googleapis-common-protos to v1.51.0 [(#3171)](GoogleCloudPlatform/python-docs-samples#3171) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [googleapis-common-protos](https://togithub.com/googleapis/googleapis) | minor | `==1.6.0` -> `==1.51.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples). * Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-samples#2806) * chore(deps): update dependency requests to v2.23.0 * Simplify noxfile and add version control. * Configure appengine/standard to only test Python 2.7. * Update Kokokro configs to match noxfile. * Add requirements-test to each folder. * Remove Py2 versions from everything execept appengine/standard. * Remove conftest.py. * Remove appengine/standard/conftest.py * Remove 'no-sucess-flaky-report' from pytest.ini. * Add GAE SDK back to appengine/standard tests. * Fix typo. * Roll pytest to python 2 version. * Add a bunch of testing requirements. * Remove typo. * Add appengine lib directory back in. * Add some additional requirements. * Fix issue with flake8 args. * Even more requirements. * Readd appengine conftest.py. * Add a few more requirements. * Even more Appengine requirements. * Add webtest for appengine/standard/mailgun. * Add some additional requirements. * Add workaround for issue with mailjet-rest. * Add responses for appengine/standard/mailjet. Co-authored-by: Renovate Bot <[email protected]> * Remove dependency googleapis-common-protos [(#3955)](GoogleCloudPlatform/python-docs-samples#3955) * Update dependency googleapis-common-protos to v1.52.0 * Update requirements.txt * Update requirements.txt * Update requirements.txt Co-authored-by: Bu Sun Kim <[email protected]> * Replace GCLOUD_PROJECT with GOOGLE_CLOUD_PROJECT. [(#4022)](GoogleCloudPlatform/python-docs-samples#4022) * [tasks] testing: use fixtures for the queue [(#4049)](GoogleCloudPlatform/python-docs-samples#4049) fixes #4045 fixes #4044 I don't know why these tests started to fail, but anyways we'd better use fixtures and temporary queues. * add python snippets and tests for creating, listing, and deleting queues [(#4012)](GoogleCloudPlatform/python-docs-samples#4012) * add python snippets and tests for creating, listing, and deleting queues * fix grammar * update licenses * apply suggested fixes and format with black * refine delete_queue_test with fixture for setup * utilize fixtures and match format of create_http_task_test * utilize fixtures in list_queues_test and create_queue_test * make create_queue_test call the right function * still attempt to delete queue after test runs in case of failure * attempt to delete queue in case of failure, using try/except approach * add print when NotFound is caught * fix import Co-authored-by: Averi Kitsch <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]> * docs(tasks): service_account_email parameter example [(#4183)](GoogleCloudPlatform/python-docs-samples#4183) * docs(tasks): serviceAccountEmail parameter example * docs(tasks): parameter name camel => snake case * docs(tasks): comment order = function param order * chore(deps): update dependency pytest to v5.4.3 [(#4279)](GoogleCloudPlatform/python-docs-samples#4279) * chore(deps): update dependency pytest to v5.4.3 * specify pytest for python 2 in appengine Co-authored-by: Leah Cole <[email protected]> * Update dependency pytest to v6 [(#4390)](GoogleCloudPlatform/python-docs-samples#4390) * tasks: added json content-type request [(#4473)](GoogleCloudPlatform/python-docs-samples#4473) - added json payload compatibility - fix imports and code block used on https://cloud.google.com/tasks/docs/creating-http-target-tasks#python ## Description Fixes #<ISSUE-NUMBER> Note: It's a good idea to open an issue first for discussion. ## Checklist - [ ] I have followed [Sample Guidelines from AUTHORING_GUIDE.MD](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md) - [ ] README is updated to include [all relevant information](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#readme-file) - [ ] **Tests** pass: `nox -s py-3.6` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#test-environment-setup)) - [ ] **Lint** pass: `nox -s lint` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#test-environment-setup)) - [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones) - [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones) - [ ] Please **merge** this PR for me once it is approved. - [ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/.github/CODEOWNERS) with the codeowners for this sample * docs: add samples from python-docs-samples/tasks * chore: update templates Co-authored-by: Andrew Gorcester <[email protected]> Co-authored-by: Andrew Gorcester <[email protected]> Co-authored-by: DPE bot <[email protected]> Co-authored-by: michaelawyu <[email protected]> Co-authored-by: ellenevans <[email protected]> Co-authored-by: Averi Kitsch <[email protected]> Co-authored-by: michaelawyu <[email protected]> Co-authored-by: Noah Negrey <[email protected]> Co-authored-by: Alex Voorhees <[email protected]> Co-authored-by: Gus Class <[email protected]> Co-authored-by: Sarath Kaul <[email protected]> Co-authored-by: Sarath Kaul <[email protected]> Co-authored-by: WhiteSource Renovate <[email protected]> Co-authored-by: Kurtis Van Gent <[email protected]> Co-authored-by: Bu Sun Kim <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]> Co-authored-by: Aaron Johnson <[email protected]> Co-authored-by: Adam Ross <[email protected]> Co-authored-by: Leah Cole <[email protected]> Co-authored-by: Joab Leite S. Neto <[email protected]>

…-samples#1068) * Add samples for Cloud Tasks * Respond to tasks sample review * Update app engine queues samples * Address review feedback * Address review issues and convert pull queue sample to not use API key auth * Reform pull queues to match appengine queues changes to auth, command line input, readme * flake8 and fix comment

* Add samples for Cloud Tasks [(#1068)](#1068) * Add samples for Cloud Tasks * Respond to tasks sample review * Update app engine queues samples * Address review feedback * Address review issues and convert pull queue sample to not use API key auth * Reform pull queues to match appengine queues changes to auth, command line input, readme * flake8 and fix comment * Fix Tasks sample test issues. * Remove queue.yaml, now unused * Add required flag on certain arguments to command-line tools * Auto-update dependencies. [(#1116)](#1116) * Auto-update dependencies. [(#1133)](#1133) * Auto-update dependencies. * Fix missing http library Change-Id: I99faa600f2f3f1f50f57694fc9835d7f35bda250 * Update Task Queue samples for beta * Use full import to get client * Auto-update dependencies. [(#1186)](#1186) * Auto-update dependencies. [(#1217)](#1217) * Added "Open in Cloud Shell" buttons to README files [(#1254)](#1254) * Add comments and region tags to Cloud Tasks samples [(#1271)](#1271) * Standardize on CamelCase, reword confusing endpoint name [(#1288)](#1288) * Auto-update dependencies. [(#1309)](#1309) * Rename pull to lease and fix name/parent confusion [(#1311)](#1311) * Updated region tags for pull queue samples [(#1329)](#1329) * Auto-update dependencies. [(#1320)](#1320) * Auto-update dependencies. [(#1355)](#1355) * Auto-update dependencies. [(#1359)](#1359) * Auto-update dependencies. * Update Cloud Tasks Samples [(#1529)](#1529) * passing create task * Passing tests * updates to region tags * update region tags [(#1532)](#1532) * update Tasks Sample for App Engine [(#1541)](#1541) * update gcloud command for creating queues * deploys and runs * update license * passing tests * Fix run command [(#1563)](#1563) * Updated library for TTS GA [(#1552)](#1552) * update gcloud command for Cloud Tasks [(#1566)](#1566) * update gcloud command * update pull queue command * update pull queue command * Update Cloud Tasks Push Queue Sample [(#1698)](#1698) * deleted pull queues * updated samples * fix dependency versions * [Cloud Tasks] Move samples to new folder [(#2114)](#2114) * Move samples to keep consistent with other langauges * Ad system tests as well * [Cloud Tasks] Add task with authentication sample [(#2113)](#2113) * Add task with authentication sample * Fix linting * Fix linting * Fix spacing * Update tests with service account * Move samples and update READMEs * Update version and linting * Update task sample comments [(#2156)](#2156) * Update task comments * Update readme * Update queue name * update gcloud [(#2208)](#2208) * Add protobuf dep and install instructions [(#2250)](#2250) * Add Migration Guide Snippets for Cloud Tasks [(#2316)](#2316) * Migration guide * remove app and update migraitonn * snippets for migration guide - tests added * lint * remove print statements * Styling changes * Travis trigger * Update create_http_task.py [(#2187)](#2187) Updates `create_http_task.py` to have missing `in_seconds` variable * Adds updates for samples profiler ... vision [(#2439)](#2439) * Update Cloud Tasks library version [(#2516)](#2516) * Update to new library * update library version * Adds Task name while creating Task [(#2543)](#2543) * Task Name in Creating HTTP Task with Token [(#2700)](#2700) * chore(deps): update dependency google-cloud-tasks to v1.5.0 [(#3168)](#3168) * chore(deps): update dependency googleapis-common-protos to v1.51.0 [(#3171)](#3171) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [googleapis-common-protos](https://togithub.com/googleapis/googleapis) | minor | `==1.6.0` -> `==1.51.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples). * Simplify noxfile setup. [(#2806)](#2806) * chore(deps): update dependency requests to v2.23.0 * Simplify noxfile and add version control. * Configure appengine/standard to only test Python 2.7. * Update Kokokro configs to match noxfile. * Add requirements-test to each folder. * Remove Py2 versions from everything execept appengine/standard. * Remove conftest.py. * Remove appengine/standard/conftest.py * Remove 'no-sucess-flaky-report' from pytest.ini. * Add GAE SDK back to appengine/standard tests. * Fix typo. * Roll pytest to python 2 version. * Add a bunch of testing requirements. * Remove typo. * Add appengine lib directory back in. * Add some additional requirements. * Fix issue with flake8 args. * Even more requirements. * Readd appengine conftest.py. * Add a few more requirements. * Even more Appengine requirements. * Add webtest for appengine/standard/mailgun. * Add some additional requirements. * Add workaround for issue with mailjet-rest. * Add responses for appengine/standard/mailjet. Co-authored-by: Renovate Bot <[email protected]> * Remove dependency googleapis-common-protos [(#3955)](#3955) * Update dependency googleapis-common-protos to v1.52.0 * Update requirements.txt * Update requirements.txt * Update requirements.txt Co-authored-by: Bu Sun Kim <[email protected]> * Replace GCLOUD_PROJECT with GOOGLE_CLOUD_PROJECT. [(#4022)](#4022) * [tasks] testing: use fixtures for the queue [(#4049)](#4049) fixes #4045 fixes #4044 I don't know why these tests started to fail, but anyways we'd better use fixtures and temporary queues. * add python snippets and tests for creating, listing, and deleting queues [(#4012)](#4012) * add python snippets and tests for creating, listing, and deleting queues * fix grammar * update licenses * apply suggested fixes and format with black * refine delete_queue_test with fixture for setup * utilize fixtures and match format of create_http_task_test * utilize fixtures in list_queues_test and create_queue_test * make create_queue_test call the right function * still attempt to delete queue after test runs in case of failure * attempt to delete queue in case of failure, using try/except approach * add print when NotFound is caught * fix import Co-authored-by: Averi Kitsch <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]> * docs(tasks): service_account_email parameter example [(#4183)](#4183) * docs(tasks): serviceAccountEmail parameter example * docs(tasks): parameter name camel => snake case * docs(tasks): comment order = function param order * chore(deps): update dependency pytest to v5.4.3 [(#4279)](#4279) * chore(deps): update dependency pytest to v5.4.3 * specify pytest for python 2 in appengine Co-authored-by: Leah Cole <[email protected]> * Update dependency pytest to v6 [(#4390)](#4390) * tasks: added json content-type request [(#4473)](#4473) - added json payload compatibility - fix imports and code block used on https://cloud.google.com/tasks/docs/creating-http-target-tasks#python ## Description Fixes #<ISSUE-NUMBER> Note: It's a good idea to open an issue first for discussion. ## Checklist - [ ] I have followed [Sample Guidelines from AUTHORING_GUIDE.MD](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md) - [ ] README is updated to include [all relevant information](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#readme-file) - [ ] **Tests** pass: `nox -s py-3.6` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#test-environment-setup)) - [ ] **Lint** pass: `nox -s lint` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#test-environment-setup)) - [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones) - [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones) - [ ] Please **merge** this PR for me once it is approved. - [ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/.github/CODEOWNERS) with the codeowners for this sample * docs: add samples from python-docs-samples/tasks * chore: update templates Co-authored-by: Andrew Gorcester <[email protected]> Co-authored-by: Andrew Gorcester <[email protected]> Co-authored-by: DPE bot <[email protected]> Co-authored-by: michaelawyu <[email protected]> Co-authored-by: ellenevans <[email protected]> Co-authored-by: Averi Kitsch <[email protected]> Co-authored-by: michaelawyu <[email protected]> Co-authored-by: Noah Negrey <[email protected]> Co-authored-by: Alex Voorhees <[email protected]> Co-authored-by: Gus Class <[email protected]> Co-authored-by: Sarath Kaul <[email protected]> Co-authored-by: Sarath Kaul <[email protected]> Co-authored-by: WhiteSource Renovate <[email protected]> Co-authored-by: Kurtis Van Gent <[email protected]> Co-authored-by: Bu Sun Kim <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]> Co-authored-by: Aaron Johnson <[email protected]> Co-authored-by: Adam Ross <[email protected]> Co-authored-by: Leah Cole <[email protected]> Co-authored-by: Joab Leite S. Neto <[email protected]>

* Add samples for Cloud Tasks [(#1068)](GoogleCloudPlatform/python-docs-samples#1068) * Add samples for Cloud Tasks * Respond to tasks sample review * Update app engine queues samples * Address review feedback * Address review issues and convert pull queue sample to not use API key auth * Reform pull queues to match appengine queues changes to auth, command line input, readme * flake8 and fix comment * Fix Tasks sample test issues. * Remove queue.yaml, now unused * Add required flag on certain arguments to command-line tools * Auto-update dependencies. [(#1116)](GoogleCloudPlatform/python-docs-samples#1116) * Auto-update dependencies. [(#1133)](GoogleCloudPlatform/python-docs-samples#1133) * Auto-update dependencies. * Fix missing http library Change-Id: I99faa600f2f3f1f50f57694fc9835d7f35bda250 * Update Task Queue samples for beta * Use full import to get client * Auto-update dependencies. [(#1186)](GoogleCloudPlatform/python-docs-samples#1186) * Auto-update dependencies. [(#1217)](GoogleCloudPlatform/python-docs-samples#1217) * Added "Open in Cloud Shell" buttons to README files [(#1254)](GoogleCloudPlatform/python-docs-samples#1254) * Add comments and region tags to Cloud Tasks samples [(#1271)](GoogleCloudPlatform/python-docs-samples#1271) * Standardize on CamelCase, reword confusing endpoint name [(#1288)](GoogleCloudPlatform/python-docs-samples#1288) * Auto-update dependencies. [(#1309)](GoogleCloudPlatform/python-docs-samples#1309) * Rename pull to lease and fix name/parent confusion [(#1311)](GoogleCloudPlatform/python-docs-samples#1311) * Updated region tags for pull queue samples [(#1329)](GoogleCloudPlatform/python-docs-samples#1329) * Auto-update dependencies. [(#1320)](GoogleCloudPlatform/python-docs-samples#1320) * Auto-update dependencies. [(#1355)](GoogleCloudPlatform/python-docs-samples#1355) * Auto-update dependencies. [(#1359)](GoogleCloudPlatform/python-docs-samples#1359) * Auto-update dependencies. * Update Cloud Tasks Samples [(#1529)](GoogleCloudPlatform/python-docs-samples#1529) * passing create task * Passing tests * updates to region tags * update region tags [(#1532)](GoogleCloudPlatform/python-docs-samples#1532) * update Tasks Sample for App Engine [(#1541)](GoogleCloudPlatform/python-docs-samples#1541) * update gcloud command for creating queues * deploys and runs * update license * passing tests * Fix run command [(#1563)](GoogleCloudPlatform/python-docs-samples#1563) * Updated library for TTS GA [(#1552)](GoogleCloudPlatform/python-docs-samples#1552) * update gcloud command for Cloud Tasks [(#1566)](GoogleCloudPlatform/python-docs-samples#1566) * update gcloud command * update pull queue command * update pull queue command * Update Cloud Tasks Push Queue Sample [(#1698)](GoogleCloudPlatform/python-docs-samples#1698) * deleted pull queues * updated samples * fix dependency versions * [Cloud Tasks] Move samples to new folder [(#2114)](GoogleCloudPlatform/python-docs-samples#2114) * Move samples to keep consistent with other langauges * Ad system tests as well * [Cloud Tasks] Add task with authentication sample [(#2113)](GoogleCloudPlatform/python-docs-samples#2113) * Add task with authentication sample * Fix linting * Fix linting * Fix spacing * Update tests with service account * Move samples and update READMEs * Update version and linting * Update task sample comments [(#2156)](GoogleCloudPlatform/python-docs-samples#2156) * Update task comments * Update readme * Update queue name * update gcloud [(#2208)](GoogleCloudPlatform/python-docs-samples#2208) * Add protobuf dep and install instructions [(#2250)](GoogleCloudPlatform/python-docs-samples#2250) * Add Migration Guide Snippets for Cloud Tasks [(#2316)](GoogleCloudPlatform/python-docs-samples#2316) * Migration guide * remove app and update migraitonn * snippets for migration guide - tests added * lint * remove print statements * Styling changes * Travis trigger * Update create_http_task.py [(#2187)](GoogleCloudPlatform/python-docs-samples#2187) Updates `create_http_task.py` to have missing `in_seconds` variable * Adds updates for samples profiler ... vision [(#2439)](GoogleCloudPlatform/python-docs-samples#2439) * Update Cloud Tasks library version [(#2516)](GoogleCloudPlatform/python-docs-samples#2516) * Update to new library * update library version * Adds Task name while creating Task [(#2543)](GoogleCloudPlatform/python-docs-samples#2543) * Task Name in Creating HTTP Task with Token [(#2700)](GoogleCloudPlatform/python-docs-samples#2700) * chore(deps): update dependency google-cloud-tasks to v1.5.0 [(#3168)](GoogleCloudPlatform/python-docs-samples#3168) * chore(deps): update dependency googleapis-common-protos to v1.51.0 [(#3171)](GoogleCloudPlatform/python-docs-samples#3171) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [googleapis-common-protos](https://togithub.com/googleapis/googleapis) | minor | `==1.6.0` -> `==1.51.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples). * Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-samples#2806) * chore(deps): update dependency requests to v2.23.0 * Simplify noxfile and add version control. * Configure appengine/standard to only test Python 2.7. * Update Kokokro configs to match noxfile. * Add requirements-test to each folder. * Remove Py2 versions from everything execept appengine/standard. * Remove conftest.py. * Remove appengine/standard/conftest.py * Remove 'no-sucess-flaky-report' from pytest.ini. * Add GAE SDK back to appengine/standard tests. * Fix typo. * Roll pytest to python 2 version. * Add a bunch of testing requirements. * Remove typo. * Add appengine lib directory back in. * Add some additional requirements. * Fix issue with flake8 args. * Even more requirements. * Readd appengine conftest.py. * Add a few more requirements. * Even more Appengine requirements. * Add webtest for appengine/standard/mailgun. * Add some additional requirements. * Add workaround for issue with mailjet-rest. * Add responses for appengine/standard/mailjet. Co-authored-by: Renovate Bot <[email protected]> * Remove dependency googleapis-common-protos [(#3955)](GoogleCloudPlatform/python-docs-samples#3955) * Update dependency googleapis-common-protos to v1.52.0 * Update requirements.txt * Update requirements.txt * Update requirements.txt Co-authored-by: Bu Sun Kim <[email protected]> * Replace GCLOUD_PROJECT with GOOGLE_CLOUD_PROJECT. [(#4022)](GoogleCloudPlatform/python-docs-samples#4022) * [tasks] testing: use fixtures for the queue [(#4049)](GoogleCloudPlatform/python-docs-samples#4049) fixes #4045 fixes #4044 I don't know why these tests started to fail, but anyways we'd better use fixtures and temporary queues. * add python snippets and tests for creating, listing, and deleting queues [(#4012)](GoogleCloudPlatform/python-docs-samples#4012) * add python snippets and tests for creating, listing, and deleting queues * fix grammar * update licenses * apply suggested fixes and format with black * refine delete_queue_test with fixture for setup * utilize fixtures and match format of create_http_task_test * utilize fixtures in list_queues_test and create_queue_test * make create_queue_test call the right function * still attempt to delete queue after test runs in case of failure * attempt to delete queue in case of failure, using try/except approach * add print when NotFound is caught * fix import Co-authored-by: Averi Kitsch <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]> * docs(tasks): service_account_email parameter example [(#4183)](GoogleCloudPlatform/python-docs-samples#4183) * docs(tasks): serviceAccountEmail parameter example * docs(tasks): parameter name camel => snake case * docs(tasks): comment order = function param order * chore(deps): update dependency pytest to v5.4.3 [(#4279)](GoogleCloudPlatform/python-docs-samples#4279) * chore(deps): update dependency pytest to v5.4.3 * specify pytest for python 2 in appengine Co-authored-by: Leah Cole <[email protected]> * Update dependency pytest to v6 [(#4390)](GoogleCloudPlatform/python-docs-samples#4390) * tasks: added json content-type request [(#4473)](GoogleCloudPlatform/python-docs-samples#4473) - added json payload compatibility - fix imports and code block used on https://cloud.google.com/tasks/docs/creating-http-target-tasks#python ## Description Fixes #<ISSUE-NUMBER> Note: It's a good idea to open an issue first for discussion. ## Checklist - [ ] I have followed [Sample Guidelines from AUTHORING_GUIDE.MD](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md) - [ ] README is updated to include [all relevant information](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#readme-file) - [ ] **Tests** pass: `nox -s py-3.6` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#test-environment-setup)) - [ ] **Lint** pass: `nox -s lint` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#test-environment-setup)) - [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones) - [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones) - [ ] Please **merge** this PR for me once it is approved. - [ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/.github/CODEOWNERS) with the codeowners for this sample * docs: add samples from python-docs-samples/tasks * chore: update templates Co-authored-by: Andrew Gorcester <[email protected]> Co-authored-by: Andrew Gorcester <[email protected]> Co-authored-by: DPE bot <[email protected]> Co-authored-by: michaelawyu <[email protected]> Co-authored-by: ellenevans <[email protected]> Co-authored-by: Averi Kitsch <[email protected]> Co-authored-by: michaelawyu <[email protected]> Co-authored-by: Noah Negrey <[email protected]> Co-authored-by: Alex Voorhees <[email protected]> Co-authored-by: Gus Class <[email protected]> Co-authored-by: Sarath Kaul <[email protected]> Co-authored-by: Sarath Kaul <[email protected]> Co-authored-by: WhiteSource Renovate <[email protected]> Co-authored-by: Kurtis Van Gent <[email protected]> Co-authored-by: Bu Sun Kim <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]> Co-authored-by: Aaron Johnson <[email protected]> Co-authored-by: Adam Ross <[email protected]> Co-authored-by: Leah Cole <[email protected]> Co-authored-by: Joab Leite S. Neto <[email protected]>

Add samples for Cloud Tasks

87c721f

andrewsg requested a review from theacodes August 11, 2017 22:25

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2017

theacodes suggested changes Aug 14, 2017

View reviewed changes

andrewsg added 2 commits August 28, 2017 17:08

Respond to tasks sample review

507a54b

Update app engine queues samples

1a43939

tristanvanech reviewed Aug 31, 2017

View reviewed changes

tristanvanech reviewed Sep 1, 2017

View reviewed changes

tristanvanech reviewed Sep 7, 2017

View reviewed changes

tristanvanech reviewed Sep 8, 2017

View reviewed changes

andrewsg requested a review from michaelawyu September 8, 2017 18:21

duggelz reviewed Sep 11, 2017

View reviewed changes

theacodes suggested changes Sep 12, 2017

View reviewed changes

andrewsg added 2 commits September 12, 2017 16:43

Address review feedback

ee920fb

Address review issues and convert pull queue sample to not use API ke…

fa4270c

…y auth

Reform pull queues to match appengine queues changes to auth, command…

4d1f228

… line input, readme

flake8 and fix comment

5e7a379

theacodes approved these changes Sep 14, 2017

View reviewed changes

theacodes merged commit 356dcb1 into GoogleCloudPlatform:master Sep 14, 2017


		See the respective READMEs for detailed instructions.

		## Contributing changes


		## Prerequisites to run locally:

		The samples require a Python environment with


		## Authentication

		To set up authentication locally, download the


		## Creating a queue

		Queues can not currently be created by the API. To create a queue using the



		@app.route('/set_payload', methods=['POST'])
		def set_payload():


		"""Sample command-line program for interacting with the Cloud Tasks API.

		Please note that Cloud Tasks is currently in alpha.


		https://console.cloud.google.com/logs
		python create_app_engine_queue_task.py --project=$PROJECT_ID --queue=QUEUE_ID --location=LOCATION_ID --payload=hello --in_seconds=30


		gcloud app deploy queue.yaml
		gcloud alpha tasks queues create-app-engine-queue "my-appengine-queue"


		On App Engine, authentication credentials will be automatically detected.

		On Compute Engine and Container Engine, authentication credentials will be


		gcloud auth application-default login

		On App Engine, authentication credentials will be automatically detected.

		@@ -0,0 +1,105 @@
		# Google Cloud Tasks App Engine Queue Samples


		Please refer to [Setting Up a Python Development Environment](https://cloud.google.com/python/setup).

		## Authentication

		print('Acknowledged task {}'.format(task['name']))


		def get_client(api_key):

Add samples for Cloud Tasks #1068

Add samples for Cloud Tasks #1068

Conversation

andrewsg commented Aug 11, 2017

andrewsg commented Aug 11, 2017

theacodes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewsg commented Aug 31, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

duggelz Sep 11, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewsg commented Sep 14, 2017 • edited Loading

andrewsg commented Sep 14, 2017

duggelz Sep 11, 2017 •

edited

Loading

andrewsg commented Sep 14, 2017 •

edited

Loading