Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow e2e tests to run in parallel #585

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Allow e2e tests to run in parallel #585

merged 1 commit into from
Oct 2, 2023

Conversation

TheSpiritXIII
Copy link
Member

@TheSpiritXIII TheSpiritXIII commented Sep 27, 2023 •
edited
Loading

Webhooks are preventing e2e tests from running in parallel. This change makes the webhook server choose a random port per test.

Original description:

Disable the webhook server by default on e2e tests

This allows us to run e2e tests in parallel after #578 is merged. 🎉 

Disabling it is easier than assigning a new port per test.

@github-actions github-actions bot requested a review from pintohutch September 27, 2023 21:28
@pintohutch pintohutch removed their request for review September 27, 2023 21:40
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/e2e-disable-server branch 2 times, most recently from c9c8194 to c8205ac Compare September 29, 2023 18:48
@bernot-dev
Copy link
Collaborator

Why does the webhook server need to be disabled?

@TheSpiritXIII
Copy link
Member Author

Why does the webhook server need to be disabled?

Updated description.

@TheSpiritXIII
Copy link
Member Author

Had an offline discussion with @bernot-dev who thinks that this change would affect the fidelity of our integration tests.

@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/e2e-disable-server branch from c8205ac to edecf1e Compare October 2, 2023 15:11
@TheSpiritXIII
Copy link
Member Author

@bernot-dev please take another look. I figured out how to enable webhook servers to be initialized on random ports.

bernot-dev
bernot-dev approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@bernot-dev bernot-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update PR title/description to reflect the actual change, but LGTM.

@TheSpiritXIII TheSpiritXIII changed the title Disable the webhook server by default on e2e tests Allow e2e tests to run in parallel Oct 2, 2023
@TheSpiritXIII TheSpiritXIII merged commit 078c4ab into main Oct 2, 2023
10 checks passed
@TheSpiritXIII TheSpiritXIII deleted the TheSpiritXIII/e2e-disable-server branch October 6, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernot-dev bernot-dev bernot-dev approved these changes

@bwplotka bwplotka Awaiting requested review from bwplotka

@maxamins maxamins Awaiting requested review from maxamins

Assignees

@pintohutch pintohutch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheSpiritXIII @bernot-dev @pintohutch