Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP middleware to rule-evaluator #582

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

maxamins
Copy link
Collaborator

This code accomplishes three goals:

  1. Remove grpc measurements since grpc is not used by the rule-evaluator.
  2. Expose the export metrics collected by export.go. In the future, we may want to measure latencies of CreateTimeSeries.
  3. Wrap Query requests sent to GCM API with an instrument RoundTripper to count return codes and measure latencies. This will give GMP more control over their SLO's and Alerts.

This PR will resolve b/300157911

@maxamins maxamins force-pushed the macxamin/rule-evaluator-metrics branch from 81549b1 to 7bab63e Compare September 26, 2023 22:12
@maxamins maxamins requested a review from bwplotka September 26, 2023 22:13
Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid & simple!

Thanks! 👍🏽

@bwplotka bwplotka merged commit 4340678 into main Sep 26, 2023
8 checks passed
@maxamins maxamins deleted the macxamin/rule-evaluator-metrics branch September 27, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants